Added flag to skip TLS verification when connection to ES #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
requested changes
Dec 14, 2022
| func addVCS(pkgpath string, doc map[string]interface{}) { | ||
| pkg, err := build.Import(pkgpath, "", build.FindOnly) | ||
| func addVCS(pkgpath string, doc map[string]interface{}) error { | ||
| pkg, err := build.Import(pkgpath, "", build.IgnoreVendor) |
There was a problem hiding this comment.
Should this be build.FindOnly | build.IgnoreVendor?
| } | ||
| resp, err := http.DefaultClient.Do(req) | ||
|
|
||
| req.WithContext(ctx) |
There was a problem hiding this comment.
Suggested change
| req.WithContext(ctx) | |
| req = req.WithContext(ctx) |
| @@ -279,7 +330,10 @@ func createMapping(cfg elasticsearchConfig) error { | |||
| req.SetBasicAuth(cfg.user, cfg.pass) | |||
| } | |||
| req.Header.Set("Content-Type", "application/json") | |||
| resp, err := http.DefaultClient.Do(req) | |||
|
|
|||
| req.WithContext(ctx) | |||
There was a problem hiding this comment.
Suggested change
| req.WithContext(ctx) | |
| req = req.WithContext(ctx) |
WithContext does not mutate the original context.
Comment on lines
+195
to
+197
| flag.BoolVar(&cfg.shouldSkipTlsVerify, "tls-verify", true, | ||
| "Should skip TLS verification.", | ||
| ) |
There was a problem hiding this comment.
The flag says "should skip ...", but the name presented to the user is "tls-verify" -- the name implies the reverse of what it's doing.
There was a problem hiding this comment.
BTW in #3 (comment), I said that the default should be true. I misread the flag as "should verify" because of the name. So what I actually want is to verify by default, and users can opt out if they like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of my last PR in this repository -> Original declined PR and I tried to implement the proposed changes.
Since Elastic 8.0 onwards Security is enabled by default Security settings in Elasticsearch .
Currently this tool has no means to handle some pretty common cases related to HTTPS communication, such as certificate verification. Currently it skips the whole certificate verification. Could be extented if the need arises.
Also, another drawback I encountered was the usage of the default http client in Go.
The way it is implemented it never timeouts, which could be a problem. I added a default limit of 600 seconds (10 minutes) to the command.
For our usecase we needed a way to identify the git author and thus added it to the mapping.
It's enabled by default for everyone, since I decided that this may be pretty common scenario, if needed I can flag it.