Add mTLS flags to 'Configure SSL/TLS' docs #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Merged
shainaraskas
approved these changes
Jun 21, 2024
| `fleet-server-es-cert-key`:: | ||
| The path to the private key that {fleet-server} will use when connecting to {es}. | ||
| `fleet-server-client-auth`:: | ||
| One of `none`, `optional`, or `required`. Defaults to `none`. {fleet-server}'s client_authentication option for client mTLS connections. If `optional` or `required` is specified, client certificates are verified using CAs specified in the `--certificate-authorities` flag. |
There was a problem hiding this comment.
Consider front-loading the description
Suggested change
| One of `none`, `optional`, or `required`. Defaults to `none`. {fleet-server}'s client_authentication option for client mTLS connections. If `optional` or `required` is specified, client certificates are verified using CAs specified in the `--certificate-authorities` flag. | |
| {fleet-server}'s client_authentication option for client mTLS connections. Accepted values: one of `none`, `optional`, or `required`. Defaults to `none`. If `optional` or `required` is specified, client certificates are verified using CAs specified in the `--certificate-authorities` flag. |
There was a problem hiding this comment.
Sorry @shainaraskas! I pulled the trigger too early and didn't notice this.
|
These settings match what's been outlined in this comment, so I think this is good to merge now. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
(cherry picked from commit 6974f74)
kilfoyle
added a commit
that referenced
this pull request
Jun 21, 2024
(cherry picked from commit 6974f74) Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Configure SSL/TLS for self-managed Fleet Servers page to include the recently added mTLS flags. I also added the
--fleet-server-policy=fleet-server-policyflag since it was missing, but I see it in the example from the mTLS flags PR.Closes: #1098