proofpoint_tap: fix interval end clamping (#11596)

The logic was previously incorrectly stretching all end points to now.
Fix this by inverting the clamp condition.

I do not see a way to test the full set of pagination conditions now
that this has been fixed; elastic-package does not provide a way to set
a testing time, which would be required to test this since the only
communication between the agent and the endpoint is via time ranges.
Since stream is stateless, we cannot know what we should expect the next
request to be. So just do a single request test, leaving the
configuration of stream the same on the basis that at some point in the
future we may figure out a way to test this.

packages/proofpoint_tap/changelog.yml

@@ -1,4 +1,9 @@
 # newer versions go on top
+- version: "1.24.3"
+  changes:
+    - description: Fix time interval clamp logic.
+      type: bugfix
+      link: https://github.com/elastic/integrations/pull/11596
 - version: "1.24.2"
   changes:
     - description: Ensure that query endpoints have been published to the stored cursor state.

packages/proofpoint_tap/data_stream/clicks_blocked/_dev/test/system/test-default-config.yml

@@ -9,4 +9,4 @@ data_stream:
   vars:
     preserve_original_event: true
 assert:
-  hit_count: 2
+  hit_count: 1

packages/proofpoint_tap/data_stream/clicks_blocked/agent/stream/httpjson.yml.hbs

@@ -34,7 +34,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -53,7 +53,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -76,7 +76,7 @@ response.pagination:
             [[- $end = .Add $hour -]]
           [[- end -]]
           [[- with $end -]]
-            [[- if .Before now -]]
+            [[- if .After now -]]
               [[- $end = now -]]
             [[- end -]]
           [[- end -]]

packages/proofpoint_tap/data_stream/clicks_permitted/_dev/test/system/test-default-config.yml

@@ -9,4 +9,4 @@ data_stream:
   vars:
     preserve_original_event: true
 assert:
-  hit_count: 2
+  hit_count: 1

packages/proofpoint_tap/data_stream/clicks_permitted/agent/stream/httpjson.yml.hbs

@@ -34,7 +34,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -53,7 +53,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -76,7 +76,7 @@ response.pagination:
             [[- $end = .Add $hour -]]
           [[- end -]]
           [[- with $end -]]
-            [[- if .Before now -]]
+            [[- if .After now -]]
               [[- $end = now -]]
             [[- end -]]
           [[- end -]]

packages/proofpoint_tap/data_stream/message_blocked/_dev/test/system/test-default-config.yml

@@ -9,4 +9,4 @@ data_stream:
   vars:
     preserve_original_event: true
 assert:
-  hit_count: 2
+  hit_count: 1

packages/proofpoint_tap/data_stream/message_blocked/agent/stream/httpjson.yml.hbs

@@ -34,7 +34,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -53,7 +53,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -76,7 +76,7 @@ response.pagination:
             [[- $end = .Add $hour -]]
           [[- end -]]
           [[- with $end -]]
-            [[- if .Before now -]]
+            [[- if .After now -]]
               [[- $end = now -]]
             [[- end -]]
           [[- end -]]

packages/proofpoint_tap/data_stream/message_delivered/_dev/test/system/test-default-config.yml

@@ -9,4 +9,4 @@ data_stream:
   vars:
     preserve_original_event: true
 assert:
-  hit_count: 2
+  hit_count: 1

packages/proofpoint_tap/data_stream/message_delivered/agent/stream/httpjson.yml.hbs

@@ -34,7 +34,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -53,7 +53,7 @@ request.transforms:
           [[- $end = .Add $hour -]]
         [[- end -]]
         [[- with $end -]]
-          [[- if .Before now -]]
+          [[- if .After now -]]
             [[- $end = now -]]
           [[- end -]]
         [[- end -]]
@@ -76,7 +76,7 @@ response.pagination:
             [[- $end = .Add $hour -]]
           [[- end -]]
           [[- with $end -]]
-            [[- if .Before now -]]
+            [[- if .After now -]]
               [[- $end = now -]]
             [[- end -]]
           [[- end -]]

packages/proofpoint_tap/manifest.yml

@@ -1,7 +1,7 @@
 format_version: "3.0.3"
 name: proofpoint_tap
 title: Proofpoint TAP
-version: "1.24.2"
+version: "1.24.3"
 description: Collect logs from Proofpoint TAP with Elastic Agent.
 type: integration
 categories: