github: Add latest transforms for issues, dependabot, code_scanning, and secret_scanning alerts #11518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcreddy
changed the title
kcreddy
changed the title
kcreddy
changed the title
kcreddy
added
enhancement
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...a_stream/secret_scanning/_dev/test/pipeline/test-ghas-secret-scanning-json.log-expected.json
Fixed
Show fixed
Hide fixed
...a_stream/secret_scanning/_dev/test/pipeline/test-ghas-secret-scanning-json.log-expected.json
Fixed
Show fixed
Hide fixed
packages/github/data_stream/secret_scanning/sample_event.json
Dismissed
Show dismissed
Hide dismissed
efd6
reviewed
Oct 28, 2024
packages/github/elasticsearch/transform/latest_issues/fields/base-fields.yml
Outdated
Show resolved
Hide resolved
packages/github/elasticsearch/transform/latest_dependabot/fields/base-fields.yml
Outdated
Show resolved
Hide resolved
packages/github/elasticsearch/transform/latest_code_scanning/fields/base-fields.yml
Outdated
Show resolved
Hide resolved
packages/github/data_stream/issues/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
Comment on lines
7
to
12
| - set: | ||
| field: event.kind | ||
| value: alert | ||
| - set: | ||
| field: event.action | ||
| value: "secret_scanning" |
There was a problem hiding this comment.
Are these something that could be a constant_keyword (similar for the other data streams)?
There was a problem hiding this comment.
Yeah, let me do that. Also, setting datastream name to event.action doesn't make much sense. I will remove this field altogether. There are few dashboards still using event.action to filter on datastream. I will have to update them to data_stream.dataset.
There was a problem hiding this comment.
Addressed in 54a4fed.
There was a problem hiding this comment.
Updated commit message and added changelog entry for the same.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
dependabot |
5025.13 | 4237.29 | -787.84 (-15.68%) | 💔 |
issues |
5347.59 | 3906.25 | -1441.34 (-26.95%) | 💔 |
secret_scanning |
11494.25 | 9615.38 | -1878.87 (-16.35%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
cc @kcreddy |
|
efd6
approved these changes
Oct 30, 2024
| "id": "", | ||
| "params": { | ||
| "fontSize": 12, | ||
| "markdown": "**Navigation**\n\n**Github** \n\n- **Audit**\n - [Audit Log Activity](#/dashboard/github-dcee84c0-2059-11ec-8b10-11a4c5e322a0)\n - [User Change Audit](#/dashboard/github-8bfd8310-205c-11ec-8b10-11a4c5e322a0)\n- **Github Advanced Security**\n - [Advanced Security Overview](#/dashboard/github-6a6d7c40-17ab-11ed-809a-7b4be950fe9c)\n - [Code Scanning](#/dashboard/github-4da91aa0-12fc-11ed-af77-016e1a977d80)\n - [**Secret Scanning (This Page)**](#/dashboard/github-591d69e0-17b6-11ed-809a-7b4be950fe9c)\n - [Dependabot](#/dashboard/github-6197be80-220c-11ed-88c4-e3caca48250a)\n- [Issues](#/dashboard/github-f0104680-ae18-11ed-83fa-df5d96a45724)\n\n**Overview**\nThis dashboard provides an overview of the events ingested from Github.\n\nThe dashboard provides details on secret scanning alerts that are open and resolved. It deep-dives into the top 10 repositories where secret scanning alerts are found. It also calculates the mean-time to resolve (or dismiss) an open secret scanning alert. The dashboard presents a view of the type of secrets that are currently open. Finally, it gives a layout of top users resolving the secret scanning alerts.\n\n[**Integrations Page**](/app/integrations/detail/github/overview)", |
There was a problem hiding this comment.
I just want to raise this issue here. I plan to raise it internally, so we can discuss then.
|
Package github - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=github |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add latest transforms for issues, dependabot, code_scanning, and secret_scanning alerts.
With the latest transform, the latest state of each event
is saved inside the destination indices. The dashboards are also updated to
the new destination indices. Hence, the dashboards no longer show
inconsistencies with events (same event in 2 states).
Other changes:
and dependabot to ingest all event updates.
Update dashboards to use corresponding datastream-level fields instead.
and issues as it is redundant. Update dashboards to use
data_stream.datasetinstead.and issues.
and secret_scanning alerts.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots
Before
After
Dashboards updated