[Elasticsearch][Ingest Pipeline] Add elasticsearch.node.name as TSDS dimension

[BenB196]

Bug

Proposed commit message

Adds elasticsearch.node.name as a TSDS dimension to prevent document collisions.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.
• I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

• [ ]

How to test this PR locally

Install assets for the Elasticsearch integration and validate that the metrics-elasticsearch.ingest_pipeline@package component template properly sets elasticsearch.node.name as "time_series_dimension": true

Related issues

• Closes [Elasticsearch Ingest Pipeline]: Missing TSDS Dimension on Elasticsearch Node Id field #11522

Screenshots

[consulthys]

Well spotted!
Thanks for the contribution

[consulthys]

Interestingly for the node_stats metric set, the elasticsearch.node.name was added as a dimension

integrations/packages/elasticsearch/data_stream/node_stats/fields/package-fields.yml

Line 319 in b7bb08a

dimension: true

Can you check this commit to see what would make the most sense regarding other metric sets?

Asking for more checks

[BenB196]

Interestingly for the node_stats metric set, the elasticsearch.node.name was added as a dimension

integrations/packages/elasticsearch/data_stream/node_stats/fields/package-fields.yml

Line 319 in b7bb08a

dimension: true

Can you check this commit to see what would make the most sense regarding other metric sets?

Taking a look at the example provided, I think either would work, service.address being a dimension should prevent collisions between clusters if 2 clusters have the same elasticsearch.node.name value and are collected by the same centralized agent.

I've pushed a commit to use node.name here as with the other one.

[consulthys]

Agreed, because elasticsearch.node.id is also not guaranteed to be unique across clusters, so either would be fine, but since other metric sets use elasticsearch.node.name it'd make sense to be consistent in this one also.

[consulthys]

LGTM

[consulthys]

/test

[elastic-vault-github-plugin-prod]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 133ef3c

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube