mimecast: squelch test errors associated with timezone short IDs #11584
+27
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BST short ID is associated with three timezones, resulting in the potential for three different Zulu timestamps, depending on which BST is chosen by the date processor. Fix this for tests by using a non-ambigous timezone short ID (which happily also agrees with the geoip data that we use). There is no correct fix that can be applied since the set of ambigous short IDs is large and knowing which to apply would depend on knowledge of the origin of the data (which may be possible, though complex with the geoip data, but also may not be depending on how strongly tied to geographical location the TZ of the timestamp is). The correct fix is for the data source to not use short IDs. We do not control this.
efd6
added
flaky-test
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The BST short ID is associated with three timezones, resulting in the potential for three different Zulu timestamps, depending on which BST is chosen by the date processor. Fix this for tests by using a non-ambigous timezone short ID (which happily also agrees with the geoip data that we use).
There is no correct fix that can be applied since the set of ambigous short IDs is large and knowing which to apply would depend on knowledge of the origin of the data (which may be possible, though complex with the geoip data, but also may not be depending on how strongly tied to geographical location the TZ of the timestamp is). The correct fix is for the data source to not use short IDs. We do not control this.
Note
No changelog entry as this is not user facing (mod the whitespace fix that is not worth a release).
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots