Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ELB add support for ALPN policy details in NLB logs #11590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

agithomas
Copy link
Contributor

  • Bug

Proposed commit message

Add support for extracting ALPN policy related details from NLB access log data.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Update the new pattern in the pipeline test files and generate new expected log data
  • Package upgrade testing

How to test this PR locally

elastic-package build && elastic-package stack up -v -d --services package-registry

Related issues

Screenshots

image

@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:aws AWS labels Oct 30, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 30, 2024

🚀 Benchmarks report

Package aws 👍(13) 💚(2) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
waf 7042.25 5917.16 -1125.09 (-15.98%) 💔
cloudwatch_logs 333333.33 250000 -83333.33 (-25%) 💔
emr_logs 20408.16 7936.51 -12471.65 (-61.11%) 💔
firewall_logs 3300.33 2551.02 -749.31 (-22.7%) 💔

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review October 30, 2024 15:06
@agithomas agithomas requested review from a team as code owners October 30, 2024 15:06
@andrewkroh andrewkroh added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Oct 30, 2024
packages/aws/changelog.yml Outdated Show resolved Hide resolved
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Rest looks good!

Copy link
Contributor

@lucian-ioan lucian-ioan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @agithomas

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding code owner approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:aws AWS Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants