Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[citrix_adc] - Parse dates more comprehensively #11599

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Oct 30, 2024

Proposed commit message

[citrix_adc] Parsing and formatting date/time strings caused failures

  • Some grok patterns were returning date/time strings with trailing spaces
  • Trailing spaces were breaking the date processing
  • The custom date format parser also didn't properly handle trailing spaces
  • A comprehensive upgrade to the custom format parsing was needed to ensure accuracy and consistency
  • Sample data was added to the pipeline tests to verify the fix

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

cd packages/citrix_adc
elastic-package build && elastic-package test

Related issues

Screenshots

@jrmolin jrmolin added the bugfix Pull request that fixes a bug issue label Oct 30, 2024
@@ -1,7 +1,6 @@
{
"expected": [
{
"@timestamp": "2015-06-22T19:14:37.000Z",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, what?

@@ -1,7 +1,6 @@
{
"expected": [
{
"@timestamp": "2024-09-09T14:13:39.000Z",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is causing this!?!?!?!?!?

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:citrix_adc Citrix ADC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants