Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cel: Add xsd configuration option to input. #11602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cel: Add xsd configuration option to input. #11602

wants to merge 2 commits into from
+32 −1

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Oct 31, 2024 •
edited
Loading

Proposed commit message

Adds xsd configuration option to input.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Screenshot 2024-10-31 at 5 31 38 PM

@kcreddy kcreddy self-assigned this Oct 31, 2024
@kcreddy kcreddy requested a review from efd6 October 31, 2024 12:03
@kcreddy kcreddy added enhancement New feature or request Integration:cel Custom API using Common Expression Language Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Oct 31, 2024
@kcreddy kcreddy marked this pull request as ready for review October 31, 2024 12:04
@kcreddy kcreddy requested a review from a team as a code owner October 31, 2024 12:04
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

efd6
efd6 reviewed Oct 31, 2024
View reviewed changes
packages/cel/manifest.yml
description: |
The XSD needed for correct parsing and ingestion of XML documents using decode_xml CEL extension.
More information can be found in the [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-cel.html#xsd-cel).
show_user: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
show_user: true
show_user: false

This in not a common enough use case for us to push it on everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kcreddy kcreddy

Labels
enhancement New feature or request Integration:cel Custom API using Common Expression Language Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcreddy @elasticmachine @efd6