Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ti_crowdstrike: Set transforms unattended setting to true. #11605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ti_crowdstrike: Set transforms unattended setting to true. #11605

wants to merge 3 commits into from
+31 −7

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Oct 31, 2024 •
edited
Loading

Proposed commit message

Set intel and ioc latest transforms' unattended setting to true.

This allow for transforms to retry indefinitely and recover from failed state.

Reference.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Screenshot 2024-10-31 at 8 44 13 PM

@kcreddy kcreddy changed the title ti_crowdstrike: Set transform unattended setting to true. ti_crowdstrike: Set transforms unattended setting to true. Oct 31, 2024
@andrewkroh andrewkroh added the Integration:ti_crowdstrike CrowdStrike Falcon Intelligence label Oct 31, 2024
@kcreddy kcreddy marked this pull request as ready for review October 31, 2024 15:47
@kcreddy kcreddy requested a review from a team as a code owner October 31, 2024 15:47
@kcreddy kcreddy added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Oct 31, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy self-assigned this Oct 31, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
11.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kcreddy

efd6
efd6 reviewed Oct 31, 2024
View reviewed changes
packages/ti_crowdstrike/_dev/build/docs/README.md
@@ -35,6 +35,9 @@ You can run Elastic Agent inside a container, either with Fleet Server or standa

There are some minimum requirements for running Elastic Agent and for more information, refer to the link [here](https://www.elastic.co/guide/en/fleet/current/elastic-agent-installation.html).

### Permissions
This integration includes assets such as latest transform which requires users installing the integration to have `kibana_system` role.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to the relevant docs for this? https://www.elastic.co/guide/en/elasticsearch/reference/current/built-in-roles.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kcreddy kcreddy

Labels
enhancement New feature or request Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcreddy @elasticmachine @efd6 @andrewkroh