Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Billing] Fix billing subscription scope in Readme #12432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Azure Billing] Fix billing subscription scope in Readme #12432

wants to merge 2 commits into from
+18 −11

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Jan 23, 2025 •
edited
Loading

Proposed commit message

This PR brings the subscription id from the either of the three billing scope. As the subscription id is default which is also used to establish API connection.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Verify the README for scope changes.

@muthu-mps muthu-mps self-assigned this Jan 23, 2025
@muthu-mps muthu-mps added the Integration:azure_billing Azure Billing Metrics label Jan 23, 2025
@elasticmachine
Copy link

💚 Build Succeeded

cc @muthu-mps

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@muthu-mps muthu-mps marked this pull request as ready for review January 23, 2025 08:11
@muthu-mps muthu-mps requested a review from a team as a code owner January 23, 2025 08:11
@muthu-mps muthu-mps requested a review from zmoog January 23, 2025 08:11
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jan 23, 2025
@stefans-elastic stefans-elastic self-requested a review January 23, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefans-elastic stefans-elastic stefans-elastic approved these changes

@zmoog zmoog Awaiting requested review from zmoog

At least 1 approving review is required to merge this pull request.

Assignees

@muthu-mps muthu-mps

Labels
bugfix Pull request that fixes a bug issue Integration:azure_billing Azure Billing Metrics Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muthu-mps @elasticmachine @stefans-elastic @andrewkroh