Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(buildkite): exclude files/folders that are not tested in Buildkite #12435

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 23, 2025

Proposed commit message

Skip files that are not used in Buildkite
Run faster builds and avoid waste of CI cycles.

I decided to support the whole .github folder since there are some other files, such as CODEOWNERS or .dependabot.yml and the rest are not used by Buildkite

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@v1v v1v self-assigned this Jan 23, 2025
@v1v v1v requested a review from a team as a code owner January 23, 2025 13:45
@elasticmachine
Copy link

elasticmachine commented Jan 23, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @v1v

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package o365_metrics 👍(4) 💚(4) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
viva_engage_groups_activity_group_detail 4545.45 3546.1 -999.35 (-21.99%) 💔
yammer_device_usage 17543.86 8333.33 -9210.53 (-52.5%) 💔
onedrive_usage 12500 8196.72 -4303.28 (-34.43%) 💔
outlook_app_usage 14084.51 10000 -4084.51 (-29%) 💔
teams_device_usage_user_counts 7042.25 4854.37 -2187.88 (-31.07%) 💔

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v enabled auto-merge (squash) January 23, 2025 18:03
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@v1v v1v merged commit 26f639f into elastic:main Jan 28, 2025
5 checks passed
harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants