[7.x] [Reporting] Move code out of Legacy (#67904) (#68201)

* [Reporting] Move code out of Legacy (#67904)

* [Reporting] Move code out of Legacy

* Elasticsearch is not a plugin dep

* add data as plugin dependo

* diff cleanup 1

* log the browser download

* Update paths in outside code for new Reporting home

* fix download test

* add numeral typing for x-pack/test

* Fix jest tests for np migration

* Shorten import paths

* remove this file, add typings to the node module

* remove local typing that has been provided by node module

* Add optional security plugin dep

* revert conflicting apm typings removal

* fix i18n

* fix snakecase whitelist

Co-authored-by: Joel Griffith <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	.ci/packer_cache.sh
#	src/dev/code_coverage/ingest_coverage/__tests__/transforms.test.js
#	src/dev/code_coverage/ingest_coverage/integration_tests/mocks/jest-combined/coverage-summary-manual-mix.json
#	x-pack/plugins/reporting/server/export_types/printable_pdf/server/create_job/index.ts

* Add back in legacy bwc route

* Kill code_coverage since it's not supposed to be here...

Co-authored-by: Tim Sullivan <[email protected]>

.ci/packer_cache.sh

@@ -42,7 +42,7 @@ tar -cf "$HOME/.kibana/bootstrap_cache/$branch.tar" \
   packages/*/node_modules \
   x-pack/node_modules \
   x-pack/legacy/plugins/*/node_modules \
-  x-pack/legacy/plugins/reporting/.chromium \
+  x-pack/plugins/reporting/.chromium \
   test/plugin_functional/plugins/*/node_modules \
   examples/*/node_modules \
   .es \

src/cli/cluster/cluster_manager.ts

@@ -261,7 +261,7 @@ export class ClusterManager {
       /debug\.log$/,
       ...pluginInternalDirsIgnore,
       fromRoot('src/legacy/server/sass/__tmp__'),
-      fromRoot('x-pack/legacy/plugins/reporting/.chromium'),
+      fromRoot('x-pack/plugins/reporting/.chromium'),
       fromRoot('x-pack/plugins/siem/cypress'),
       fromRoot('x-pack/plugins/apm/e2e'),
       fromRoot('x-pack/plugins/apm/scripts'),

src/dev/build/tasks/clean_tasks.js

@@ -206,7 +206,7 @@ export const CleanExtraBrowsersTask = {
 
   async run(config, log, build) {
     const getBrowserPathsForPlatform = (platform) => {
-      const reportingDir = 'x-pack/legacy/plugins/reporting';
+      const reportingDir = 'x-pack/plugins/reporting';
       const chromiumDir = '.chromium';
       const chromiumPath = (p) =>
         build.resolvePathForPlatform(platform, reportingDir, chromiumDir, p);

src/dev/precommit_hook/casing_check_config.js

@@ -172,12 +172,12 @@ export const TEMPORARILY_IGNORED_PATHS = [
   'x-pack/plugins/monitoring/public/icons/health-green.svg',
   'x-pack/plugins/monitoring/public/icons/health-red.svg',
   'x-pack/plugins/monitoring/public/icons/health-yellow.svg',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/fonts/noto/NotoSansCJKtc-Medium.ttf',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/fonts/noto/NotoSansCJKtc-Regular.ttf',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Italic.ttf',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Medium.ttf',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Regular.ttf',
-  'x-pack/legacy/plugins/reporting/export_types/printable_pdf/server/lib/pdf/assets/img/logo-grey.png',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/fonts/noto/NotoSansCJKtc-Medium.ttf',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/fonts/noto/NotoSansCJKtc-Regular.ttf',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Italic.ttf',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Medium.ttf',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/fonts/roboto/Roboto-Regular.ttf',
+  'x-pack/plugins/reporting/server/export_types/printable_pdf/server/lib/pdf/assets/img/logo-grey.png',
   'x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/data.json.gz',
   'x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/mappings.json',
   'x-pack/test/functional/es_archives/monitoring/logstash-pipelines/data.json.gz',

x-pack/.gitignore

@@ -5,8 +5,8 @@
 /test/functional/screenshots
 /test/functional/apps/reporting/reports/session
 /test/reporting/configs/failure_debug/
-/legacy/plugins/reporting/.chromium/
-/legacy/plugins/reporting/.phantom/
+/plugins/reporting/.chromium/
+/plugins/reporting/.phantom/
 /.aws-config.json
 /.env
 /.kibana-plugin-helpers.dev.*

x-pack/.i18nrc.json

@@ -35,7 +35,7 @@
     "xpack.monitoring": ["plugins/monitoring", "legacy/plugins/monitoring"],
     "xpack.remoteClusters": "plugins/remote_clusters",
     "xpack.painlessLab": "plugins/painless_lab",
-    "xpack.reporting": ["plugins/reporting", "legacy/plugins/reporting"],
+    "xpack.reporting": ["plugins/reporting"],
     "xpack.rollupJobs": ["legacy/plugins/rollup", "plugins/rollup"],
     "xpack.searchProfiler": "plugins/searchprofiler",
     "xpack.security": ["legacy/plugins/security", "plugins/security"],

x-pack/.kibana-plugin-helpers.json

@@ -13,8 +13,8 @@
     "index.js",
     ".i18nrc.json",
     "plugins/**/*",
-    "legacy/plugins/reporting/.phantom/*",
-    "legacy/plugins/reporting/.chromium/*",
+    "plugins/reporting/.phantom/*",
+    "plugins/reporting/.chromium/*",
     "legacy/common/**/*",
     "legacy/plugins/**/*",
     "legacy/server/**/*",

x-pack/build_chromium/README.md

@@ -110,7 +110,7 @@ To run the build, replace the sha in the following commands with the sha that yo
 
 After the build completes, there will be a .zip file and a .md5 file in `~/chromium/chromium/src/out/headless`. These are named like so: `chromium-{first_7_of_SHA}-{platform}`, for example: `chromium-4747cc2-linux`.
 
-The zip files need to be deployed to s3. For testing, I drop them into `headless-shell-dev`, but for production, they need to be in `headless-shell`. And the `x-pack/legacy/plugins/reporting/server/browsers/chromium/paths.js` file needs to be upated to have the correct `archiveChecksum`, `archiveFilename`, `binaryChecksum` and `baseUrl`. Below is a list of what the archive's are:
+The zip files need to be deployed to s3. For testing, I drop them into `headless-shell-dev`, but for production, they need to be in `headless-shell`. And the `x-pack/plugins/reporting/server/browsers/chromium/paths.ts` file needs to be upated to have the correct `archiveChecksum`, `archiveFilename`, `binaryChecksum` and `baseUrl`. Below is a list of what the archive's are:
 
 - `archiveChecksum`: The contents of the `.md5` file, which is the `md5` checksum of the zip file.
 - `binaryChecksum`: The `md5` checksum of the `headless_shell` binary itself.

x-pack/index.js

@@ -6,7 +6,6 @@
 
 import { xpackMain } from './legacy/plugins/xpack_main';
 import { monitoring } from './legacy/plugins/monitoring';
-import { reporting } from './legacy/plugins/reporting';
 import { security } from './legacy/plugins/security';
 import { dashboardMode } from './legacy/plugins/dashboard_mode';
 import { beats } from './legacy/plugins/beats_management';
@@ -18,7 +17,6 @@ module.exports = function (kibana) {
   return [
     xpackMain(kibana),
     monitoring(kibana),
-    reporting(kibana),
     spaces(kibana),
     security(kibana),
     dashboardMode(kibana),

x-pack/plugins/maps/public/connected_components/gis_map/view.js

@@ -64,7 +64,7 @@ export class GisMap extends Component {
   // - If it's not, then reporting injects a listener into the browser for a custom "renderComplete" event.
   // - When that event is fired, we snapshot the viz and move on.
   // Failure to not have the dom attribute, or custom event, will timeout the job.
-  // See x-pack/legacy/plugins/reporting/export_types/common/lib/screenshots/wait_for_render.ts for more.
+  // See x-pack/plugins/reporting/export_types/common/lib/screenshots/wait_for_render.ts for more.
   _onInitialLoadRenderComplete = () => {
     const el = document.querySelector(`[data-dom-id="${this.state.domId}"]`);
 

x-pack/plugins/reporting/common/index.ts

@@ -5,3 +5,4 @@
  */
 
 export { CancellationToken } from './cancellation_token';
+export { Poller } from './poller';

x-pack/plugins/reporting/common/types.ts

@@ -5,7 +5,7 @@
  */
 
 // eslint-disable-next-line @kbn/eslint/no-restricted-paths
-export { ConfigType } from '../server/config';
+export { ReportingConfigType } from '../server/config';
 
 export type JobId = string;
 export type JobStatus =

x-pack/plugins/reporting/kibana.json

@@ -3,18 +3,18 @@
   "version": "8.0.0",
   "kibanaVersion": "kibana",
   "optionalPlugins": [
+    "security",
     "usageCollection"
   ],
   "configPath": ["xpack", "reporting"],
   "requiredPlugins": [
+    "data",
     "home",
     "management",
     "licensing",
     "uiActions",
     "embeddable",
-    "share",
-    "kibanaLegacy",
-    "licensing"
+    "share"
   ],
   "server": true,
   "ui": true

x-pack/plugins/reporting/public/plugin.tsx

@@ -26,7 +26,7 @@ import {
 import { ManagementSectionId, ManagementSetup } from '../../../../src/plugins/management/public';
 import { SharePluginSetup } from '../../../../src/plugins/share/public';
 import { LicensingPluginSetup } from '../../licensing/public';
-import { ConfigType, JobId, JobStatusBuckets } from '../common/types';
+import { ReportingConfigType, JobId, JobStatusBuckets } from '../common/types';
 import { JOB_COMPLETION_NOTIFICATIONS_SESSION_KEY } from '../constants';
 import { getGeneralErrorToast } from './components';
 import { ReportListing } from './components/report_listing';
@@ -37,7 +37,7 @@ import { csvReportingProvider } from './share_context_menu/register_csv_reportin
 import { reportingPDFPNGProvider } from './share_context_menu/register_pdf_png_reporting';
 
 export interface ClientConfigType {
-  poll: ConfigType['poll'];
+  poll: ReportingConfigType['poll'];
 }
 
 function getStored(): JobId[] {

x-pack/legacy/plugins/reporting/server/browsers/chromium/driver/chromium_driver.ts → x-pack/plugins/reporting/server/browsers/chromium/driver/chromium_driver.ts

@@ -9,7 +9,7 @@ import { map, trunc } from 'lodash';
 import open from 'opn';
 import { ElementHandle, EvaluateFn, Page, Response, SerializableOrJSHandle } from 'puppeteer';
 import { parse as parseUrl } from 'url';
-import { ViewZoomWidthHeight } from '../../../../export_types/common/layouts/layout';
+import { ViewZoomWidthHeight } from '../../../export_types/common/layouts/layout';
 import { LevelLogger } from '../../../lib';
 import { ConditionalHeaders, ElementPosition } from '../../../types';
 import { allowRequest, NetworkPolicy } from '../../network_policy';