[8.10] chore(NA): upgrade typescript into v4.7.4 (#162738) (#164758)

# Backport This will backport the following commits from `main` to `8.10`: - [chore(NA): upgrade typescript into v4.7.4 (#162738)](#162738)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: kibanamachine <[email protected]>
elastic · Aug 24, 2023 · 4e26eeb · 4e26eeb
1 parent f7aeb6c
commit 4e26eeb
Show file tree

Hide file tree

Showing 37 changed files with 82 additions and 46 deletions.
diff --git a/package.json b/package.json
@@ -84,7 +84,7 @@
     "**/hoist-non-react-statics": "^3.3.2",
     "**/isomorphic-fetch/node-fetch": "^2.6.7",
     "**/remark-parse/trim": "1.0.1",
-    "**/typescript": "4.6.3",
+    "**/typescript": "4.7.4",
     "globby/fast-glob": "^3.2.11"
   },
   "dependencies": {
@@ -1550,7 +1550,7 @@
     "tree-kill": "^1.2.2",
     "ts-morph": "^13.0.2",
     "tsd": "^0.20.0",
-    "typescript": "4.6.3",
+    "typescript": "4.7.4",
     "url-loader": "^2.2.0",
     "val-loader": "^1.1.1",
     "vinyl-fs": "^4.0.0",

diff --git a/packages/core/http/core-http-router-server-internal/src/request.ts b/packages/core/http/core-http-router-server-internal/src/request.ts
@@ -141,7 +141,7 @@ export class CoreKibanaRequest<
   public readonly rewrittenUrl?: URL;
 
   /** @internal */
-  protected readonly [requestSymbol]: Request;
+  protected readonly [requestSymbol]!: Request;
 
   constructor(
     request: RawRequest,

diff --git a/...es/core/http/core-http-router-server-internal/src/versioned_router/route_version_utils.ts b/...es/core/http/core-http-router-server-internal/src/versioned_router/route_version_utils.ts
@@ -52,7 +52,9 @@ type KibanaRequestWithQueryVersion = KibanaRequest<
   { [ELASTIC_HTTP_VERSION_QUERY_PARAM]: unknown }
 >;
 
-export function hasQueryVersion(request: KibanaRequest): request is KibanaRequestWithQueryVersion {
+export function hasQueryVersion(
+  request: Mutable<KibanaRequest>
+): request is Mutable<KibanaRequestWithQueryVersion> {
   return isObject(request.query) && ELASTIC_HTTP_VERSION_QUERY_PARAM in request.query;
 }
 export function removeQueryVersion(request: Mutable<KibanaRequestWithQueryVersion>): void {

diff --git a/packages/kbn-repo-packages/modern/plugins.js b/packages/kbn-repo-packages/modern/plugins.js
@@ -107,11 +107,7 @@ function getPluginPackagesFilter(selector = {}) {
  */
 function getDistributablePacakgesFilter() {
   return (pkg) => {
-    if (
-      pkg.isDevOnly ||
-      pkg.manifest.type === 'functional-tests' ||
-      pkg.manifest.type === 'test-helper'
-    ) {
+    if (pkg.isDevOnly()) {
       return false;
     }
 

diff --git a/packages/kbn-telemetry-tools/src/tools/ts_program/ts_program.test.ts b/packages/kbn-telemetry-tools/src/tools/ts_program/ts_program.test.ts
@@ -21,7 +21,7 @@ describe('createKibanaProgram', () => {
             "fetch": Object {
               "typeDescriptor": Object {
                 "locale": Object {
-                  "kind": 149,
+                  "kind": 150,
                   "type": "StringKeyword",
                 },
               },

diff --git a/src/plugins/charts/common/static/components/collections.ts b/src/plugins/charts/common/static/components/collections.ts
@@ -20,6 +20,7 @@ export const LabelRotation = Object.freeze({
   Horizontal: 0,
   Vertical: 90,
   Angled: 75,
+  VerticalRotation: 270,
 });
 export type LabelRotation = $Values<typeof LabelRotation>;
 

diff --git a/src/plugins/discover/public/components/doc_table/components/table_row.tsx b/src/plugins/discover/public/components/doc_table/components/table_row.tsx
@@ -186,7 +186,9 @@ export const TableRow = ({
         // We should improve this and show a helpful tooltip why the filter buttons are not
         // there/disabled when there are ignored values.
         const isFilterable = Boolean(
-          mapping(column)?.filterable && filter && !row.raw._ignored?.includes(column)
+          mapping(column)?.filterable &&
+            typeof filter === 'function' &&
+            !row.raw._ignored?.includes(column)
         );
         rowCells.push(
           <TableCell

diff --git a/src/plugins/expressions/common/execution/execution.ts b/src/plugins/expressions/common/execution/execution.ts
@@ -420,18 +420,20 @@ export class Execution<
             : of(resolvedArgs);
 
           return args$.pipe(
-            tap((args) => this.execution.params.debug && Object.assign(head.debug, { args })),
+            tap((args) => this.execution.params.debug && Object.assign(head.debug ?? {}, { args })),
             switchMap((args) => this.invokeFunction(fn, input, args)),
             this.execution.params.partial ? identity : last(),
             switchMap((output) => (getType(output) === 'error' ? throwError(output) : of(output))),
-            tap((output) => this.execution.params.debug && Object.assign(head.debug, { output })),
+            tap(
+              (output) => this.execution.params.debug && Object.assign(head.debug ?? {}, { output })
+            ),
             switchMap((output) => this.invokeChain<ChainOutput>(tail, output)),
             catchError((rawError) => {
               const error = createError(rawError);
               error.error.message = `[${fnName}] > ${error.error.message}`;
 
               if (this.execution.params.debug) {
-                Object.assign(head.debug, { error, rawError, success: false });
+                Object.assign(head.debug ?? {}, { error, rawError, success: false });
               }
 
               return of(error);
@@ -440,7 +442,7 @@ export class Execution<
         }),
         finalize(() => {
           if (this.execution.params.debug) {
-            Object.assign(head.debug, { duration: now() - timeStart });
+            Object.assign(head.debug ?? {}, { duration: now() - timeStart });
           }
         })
       );

diff --git a/src/plugins/expressions/common/expression_functions/expression_function_parameter.ts b/src/plugins/expressions/common/expression_functions/expression_function_parameter.ts
@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { KnownTypeToString } from '../types';
+import { TypeString } from '../types';
 import { ArgumentType } from './arguments';
 
 export class ExpressionFunctionParameter<T = unknown> {
@@ -46,6 +46,6 @@ export class ExpressionFunctionParameter<T = unknown> {
   }
 
   accepts(type: string) {
-    return !this.types?.length || this.types.includes(type as KnownTypeToString<T>);
+    return !this.types?.length || this.types.includes(type as TypeString<T>);
   }
 }
diff --git a/src/plugins/vis_types/xy/public/editor/components/options/metrics_axes/label_options.tsx b/src/plugins/vis_types/xy/public/editor/components/options/metrics_axes/label_options.tsx
@@ -13,7 +13,7 @@ import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 
 import { SelectOption, SwitchOption } from '@kbn/vis-default-editor-plugin/public';
-import { Labels } from '@kbn/charts-plugin/public';
+import type { LabelRotation, Labels } from '@kbn/charts-plugin/public';
 
 import { TruncateLabelsOption } from '../../common';
 import { getRotateOptions } from '../../../collections';
@@ -34,7 +34,8 @@ function LabelOptions({
 }: LabelOptionsProps) {
   const setAxisLabelRotate = useCallback(
     (paramName: 'rotate', value: Labels['rotate']) => {
-      setAxisLabel(paramName, Number(value));
+      const rotation = Number(value) as LabelRotation;
+      setAxisLabel(paramName, rotation);
     },
     [setAxisLabel]
   );
@@ -96,6 +97,7 @@ function LabelOptions({
               options={rotateOptions}
               paramName="rotate"
               value={axisLabels.rotate}
+              // @ts-ignore ts upgrade v4.7.4
               setValue={setAxisLabelRotate}
             />
           </EuiToolTip>

diff --git a/.../plugins/canvas/public/components/workpad_page/workpad_interactive_page/event_handlers.ts b/.../plugins/canvas/public/components/workpad_page/workpad_interactive_page/event_handlers.ts
@@ -61,7 +61,8 @@ const setupHandler = (commit: CommitFn, canvasOrigin: CanvasOriginFn, zoomScale?
 
     // only commits the cursor position if there's a way to latch onto x/y calculation (canvasOrigin is knowable)
     // or if left button is being held down (i.e. an element is being dragged)
-    if (buttons === 1 || canvasOrigin) {
+    //
+    if (buttons === 1 || canvasOrigin !== undefined) {
       commit('cursorPosition', { x, y, altKey, metaKey, shiftKey, ctrlKey });
     } else {
       // clears cursorPosition

diff --git a/x-pack/plugins/cases/public/components/create/form.test.tsx b/x-pack/plugins/cases/public/components/create/form.test.tsx
@@ -69,6 +69,7 @@ describe('CreateCaseForm', () => {
     globalForm = form;
 
     return (
+      // @ts-expect-error ts upgrade v4.7.4
       <TestProviders {...testProviderProps}>
         <Form form={form}>{children}</Form>
       </TestProviders>

diff --git a/x-pack/plugins/cases/public/components/markdown_editor/editable_markdown_renderer.test.tsx b/x-pack/plugins/cases/public/components/markdown_editor/editable_markdown_renderer.test.tsx
@@ -72,6 +72,7 @@ describe('EditableMarkdown', () => {
     });
 
     return (
+      // @ts-expect-error ts upgrade v4.7.4
       <TestProviders {...testProviderProps}>
         <Form form={form}>{children}</Form>
       </TestProviders>

diff --git a/x-pack/plugins/fleet/common/experimental_features.ts b/x-pack/plugins/fleet/common/experimental_features.ts
@@ -46,6 +46,7 @@ export const parseExperimentalConfigValue = (configValue: string[]): Experimenta
       throw new FleetInvalidExperimentalValue(`[${value}] is not a supported experimental feature`);
     }
 
+    // @ts-expect-error ts upgrade v4.7.4
     enabledFeatures[value as keyof ExperimentalFeatures] = true;
   }
 

diff --git a/...ations/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.test.tsx b/...ations/fleet/sections/agent_policy/components/agent_policy_advanced_fields/index.test.tsx
@@ -54,6 +54,7 @@ describe('Agent policy advanced options content', () => {
     // remove when feature flag is removed
     ExperimentalFeaturesService.init({
       ...allowedExperimentalValues,
+      // @ts-expect-error ts upgrade v4.7.4
       agentTamperProtectionEnabled: true,
     });
 

diff --git a/...ck/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.test.tsx b/...ck/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.test.tsx
@@ -40,6 +40,7 @@ describe('AgentPolicyListPage', () => {
     // todo: this can be removed when agentTamperProtectionEnabled feature flag is enabled/deleted
     ExperimentalFeaturesService.init({
       ...allowedExperimentalValues,
+      // @ts-expect-error ts upgrade v4.7.4
       agentTamperProtectionEnabled: true,
     });
 

diff --git a/...ck/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.test.tsx b/...ck/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/index.test.tsx
@@ -286,6 +286,7 @@ describe('agent_list_page', () => {
       // todo: this can be removed when agentTamperProtectionEnabled feature flag is enabled/deleted
       ExperimentalFeaturesService.init({
         ...allowedExperimentalValues,
+        // @ts-expect-error ts upgrade v4.7.4
         agentTamperProtectionEnabled: true,
       });
 

diff --git a/x-pack/plugins/fleet/server/mocks/index.ts b/x-pack/plugins/fleet/server/mocks/index.ts
@@ -71,6 +71,7 @@ export const createAppContextStartContractMock = (
     securitySetup: securityMock.createSetup(),
     securityStart: securityMock.createStart(),
     logger: loggingSystemMock.create().get(),
+    // @ts-expect-error ts upgrade v4.7.4
     experimentalFeatures: {
       agentTamperProtectionEnabled: true,
       diagnosticFileUploadEnabled: true,

diff --git a/x-pack/plugins/lists/server/services/extension_points/extension_point_storage_client.ts b/x-pack/plugins/lists/server/services/extension_points/extension_point_storage_client.ts
@@ -45,6 +45,7 @@ export class ExtensionPointStorageClient implements ExtensionPointStorageClientI
   async pipeRun<
     T extends ExtensionPoint['type'],
     D extends NarrowExtensionPointToType<T> = NarrowExtensionPointToType<T>,
+    // @ts-expect-error ts upgrade v4.7.4
     P extends Parameters<D['callback']> = Parameters<D['callback']>
   >(
     extensionType: T,

diff --git a/x-pack/plugins/lists/server/services/extension_points/types.ts b/x-pack/plugins/lists/server/services/extension_points/types.ts
@@ -185,6 +185,7 @@ export interface ExtensionPointStorageClientInterface {
   pipeRun<
     T extends ExtensionPoint['type'],
     D extends NarrowExtensionPointToType<T> = NarrowExtensionPointToType<T>,
+    // @ts-expect-error ts upgrade v4.7.4
     P extends Parameters<D['callback']> = Parameters<D['callback']>
   >(
     extensionType: T,

diff --git a/x-pack/plugins/monitoring/public/application/pages/apm/overview.tsx b/x-pack/plugins/monitoring/public/application/pages/apm/overview.tsx
@@ -70,7 +70,10 @@ export const ApmOverviewPage: React.FC<ComponentProps> = ({ clusters }) => {
       getPageData={getPageData}
       data-test-subj="apmOverviewPage"
     >
-      {data && <ApmOverview {...data} onBrush={onBrush} zoomInfo={zoomInfo} />}
+      {
+        // @ts-expect-error ts upgrade v4.7.4
+        data && <ApmOverview {...data} onBrush={onBrush} zoomInfo={zoomInfo} />
+      }
     </ApmTemplate>
   );
 };
diff --git a/x-pack/plugins/monitoring/public/application/pages/enterprise_search/overview.tsx b/x-pack/plugins/monitoring/public/application/pages/enterprise_search/overview.tsx
@@ -69,7 +69,10 @@ export const EntSearchOverviewPage: React.FC<ComponentProps> = ({ clusters }) =>
       data-test-subj="entSearchOverviewPage"
     >
       <div data-test-subj="entSearchOverviewPage">
-        {data && <EnterpriseSearchOverview {...data} onBrush={onBrush} zoomInfo={zoomInfo} />}
+        {
+          // @ts-expect-error ts upgrade v4.7.4
+          data && <EnterpriseSearchOverview {...data} onBrush={onBrush} zoomInfo={zoomInfo} />
+        }
       </div>
     </EntSearchTemplate>
   );

diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/browser_fields/index.ts b/x-pack/plugins/rule_registry/server/alert_data_client/browser_fields/index.ts
@@ -36,6 +36,7 @@ export const fieldDescriptorToBrowserFieldMapper = (fields: FieldDescriptor[]):
     const browserField = browserFieldFactory(field, category);
 
     if (browserFields[category] && browserFields[category]) {
+      // @ts-expect-error ts upgrade to v4.7.4
       Object.assign(browserFields[category].fields, browserField);
     } else {
       browserFields[category] = { fields: browserField };

diff --git a/x-pack/plugins/security/server/authentication/authenticator.ts b/x-pack/plugins/security/server/authentication/authenticator.ts
@@ -260,7 +260,7 @@ export class Authenticator {
               ...providerCommonOptions,
               name,
               logger: options.loggers.get(type, name),
-              urls: { loggedOut: (request) => this.getLoggedOutURL(request, type) },
+              urls: { loggedOut: (request: KibanaRequest) => this.getLoggedOutURL(request, type) },
             }),
             this.options.config.authc.providers[type]?.[name]
           ),
@@ -276,7 +276,8 @@ export class Authenticator {
           name: '__http__',
           logger: options.loggers.get(HTTPAuthenticationProvider.type),
           urls: {
-            loggedOut: (request) => this.getLoggedOutURL(request, HTTPAuthenticationProvider.type),
+            loggedOut: (request: KibanaRequest) =>
+              this.getLoggedOutURL(request, HTTPAuthenticationProvider.type),
           },
         })
       );

diff --git a/x-pack/plugins/security/server/session_management/session_index.ts b/x-pack/plugins/security/server/session_management/session_index.ts
@@ -106,16 +106,18 @@ export function getSessionIndexSettings({
       },
     },
     mappings: {
-      dynamic: 'strict',
+      dynamic: 'strict' as const,
       _meta: { [SESSION_INDEX_MAPPINGS_VERSION_META_FIELD_NAME]: SESSION_INDEX_MAPPINGS_VERSION },
       properties: {
-        usernameHash: { type: 'keyword' },
-        provider: { properties: { name: { type: 'keyword' }, type: { type: 'keyword' } } },
-        idleTimeoutExpiration: { type: 'date' },
-        createdAt: { type: 'date' },
-        lifespanExpiration: { type: 'date' },
-        accessAgreementAcknowledged: { type: 'boolean' },
-        content: { type: 'binary' },
+        usernameHash: { type: 'keyword' as const },
+        provider: {
+          properties: { name: { type: 'keyword' as const }, type: { type: 'keyword' as const } },
+        },
+        idleTimeoutExpiration: { type: 'date' as const },
+        createdAt: { type: 'date' as const },
+        lifespanExpiration: { type: 'date' as const },
+        accessAgreementAcknowledged: { type: 'boolean' as const },
+        content: { type: 'binary' as const },
       },
     },
   });

diff --git a/x-pack/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx b/x-pack/plugins/security_solution/public/common/mock/endpoint/app_context_render.tsx
@@ -211,10 +211,14 @@ export const createAppRootMockRenderer = (): AppContextTestRender => {
     app: experimentalFeaturesReducer,
   };
 
-  const store = createStore(mockGlobalState, storeReducer, kibanaObservable, storage, [
-    ...managementMiddlewareFactory(coreStart, depsStart),
-    middlewareSpy.actionSpyMiddleware,
-  ]);
+  const store = createStore(
+    mockGlobalState,
+    storeReducer,
+    kibanaObservable,
+    storage,
+    // @ts-expect-error ts upgrade v4.7.4
+    [...managementMiddlewareFactory(coreStart, depsStart), middlewareSpy.actionSpyMiddleware]
+  );
 
   const queryClient = new QueryClient({
     defaultOptions: {

diff --git a/...olution/public/detection_engine/rule_response_actions/osquery/osquery_response_action.tsx b/...olution/public/detection_engine/rule_response_actions/osquery/osquery_response_action.tsx
@@ -85,6 +85,7 @@ export const OsqueryResponseAction = React.memo((props: OsqueryResponseActionPro
       );
     }
 
+    // @ts-expect-error ts upgrade v4.7.4
     if (isMounted() && OsqueryForm) {
       return (
         <UseField

diff --git a/x-pack/plugins/security_solution/public/management/components/page_overlay/page_overlay.tsx b/x-pack/plugins/security_solution/public/management/components/page_overlay/page_overlay.tsx
@@ -264,6 +264,7 @@ export const PageOverlay = memo<PageOverlayProps>(
     useEffect(() => {
       if (
         isMounted() &&
+        // @ts-expect-error ts upgrade v4.7.4
         onHide &&
         hideOnUrlPathnameChange &&
         !isHidden &&

diff --git a/...ic/management/pages/policy/view/policy_settings_form/components/event_collection_card.tsx b/...ic/management/pages/policy/view/policy_settings_form/components/event_collection_card.tsx
@@ -134,7 +134,7 @@ export const EventCollectionCard = memo(
 
         <div data-test-subj={getTestId('options')}>
           {options.map(({ name, protectionField }) => {
-            const keyPath = `${policyOs}.events.${protectionField}`;
+            const keyPath = `${policyOs}.events.${String(protectionField)}`;
 
             return (
               <EventCheckbox
@@ -165,7 +165,7 @@ export const EventCollectionCard = memo(
               indented,
               isDisabled,
             }) => {
-              const keyPath = `${policyOs}.events.${protectionField}`;
+              const keyPath = `${policyOs}.events.${String(protectionField)}`;
               const isChecked = get(policy, keyPath);
               const fieldString = protectionField as string;
 

diff --git a/x-pack/plugins/security_solution/tsconfig.json b/x-pack/plugins/security_solution/tsconfig.json
@@ -12,8 +12,7 @@
     "server/**/*.json",
     "scripts/**/*.json",
     "public/**/*.json",
-    "../../../typings/**/*",
-    "./public/management/cypress/cypress.d.ts"
+    "../../../typings/**/*"
   ],
   "exclude": [
     "target/**/*",

diff --git a/x-pack/plugins/triggers_actions_ui/.storybook/decorator.tsx b/x-pack/plugins/triggers_actions_ui/.storybook/decorator.tsx
@@ -58,11 +58,13 @@ export const StorybookContextDecorator: React.FC<StorybookContextDecoratorProps>
   ExperimentalFeaturesService.init({
     experimentalFeatures: {
       rulesListDatagrid: true,
+      // @ts-expect-error ts upgrade v4.7.4
       internalAlertsTable: true,
       ruleTagFilter: true,
       ruleStatusFilter: true,
       rulesDetailLogs: true,
       ruleUseExecutionStatus: false,
+      // @ts-expect-error ts upgrade v4.7.4
       ruleKqlBar: true,
     },
   });