Always throw error objects - never strings (#171498)

elastic · Nov 20, 2023 · 4f9094c · 4f9094c
1 parent 9523a78
commit 4f9094c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/preinstall_check.js b/preinstall_check.js
@@ -10,7 +10,7 @@
   const isUsingNpm = process.env.npm_config_git !== undefined;
 
   if (isUsingNpm) {
-    throw `Use Yarn instead of npm, see Kibana's contributing guidelines`;
+    throw new Error(`Use Yarn instead of npm, see Kibana's contributing guidelines`);
   }
 
   // The value of the `npm_config_argv` env for each command:

diff --git a/src/plugins/console/public/lib/autocomplete/body_completer.js b/src/plugins/console/public/lib/autocomplete/body_completer.js
@@ -266,7 +266,7 @@ function compileCondition(description, compiledObject) {
       return new RegExp(description.lines_regex, 'm').test(lines);
     }, compiledObject);
   } else {
-    throw 'unknown condition type - got: ' + JSON.stringify(description);
+    throw new Error(`unknown condition type - got: ${JSON.stringify(description)}`);
   }
 }
 

diff --git a/x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_chart_distribution.js b/x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_chart_distribution.js
@@ -177,7 +177,7 @@ export class ExplorerChartDistribution extends React.Component {
           .rangePoints([rowMargin, chartHeight - rowMargin])
           .domain(scaleCategories);
       } else {
-        throw `chartType '${chartType}' not supported`;
+        throw new Error(`chartType '${chartType}' not supported`);
       }
 
       const yAxis = d3.svg

diff --git a/x-pack/test/api_integration/apis/maps/migrations.js b/x-pack/test/api_integration/apis/maps/migrations.js
@@ -75,7 +75,7 @@ export default function ({ getService }) {
         try {
           panels = JSON.parse(resp.body.attributes.panelsJSON);
         } catch (error) {
-          throw 'Unable to parse panelsJSON from dashboard saved object';
+          throw new Error('Unable to parse panelsJSON from dashboard saved object');
         }
         expect(panels.length).to.be(1);
         expect(panels[0].type).to.be('map');