Skip to content

Commit

Permalink
[8.x] [Security Solution][Notes] - add new notes icon for manage page (
Browse files Browse the repository at this point in the history
…#194752) (#194844)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - add new notes icon for manage page
(#194752)](#194752)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T14:01:21Z","message":"[Security
Solution][Notes] - add new notes icon for manage page
(#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
add new notes icon for manage
page","number":194752,"url":"https://github.com/elastic/kibana/pull/194752","mergeCommit":{"message":"[Security
Solution][Notes] - add new notes icon for manage page
(#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194752","number":194752,"mergeCommit":{"message":"[Security
Solution][Notes] - add new notes icon for manage page
(#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <[email protected]>
  • Loading branch information
kibanamachine and PhilippeOberti authored Oct 3, 2024
1 parent 613cab6 commit 5998ecd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*/

import { ExternalPageName, SecurityPageName } from '@kbn/security-solution-navigation';
import IconFilebeatChart from './icons/filebeat_chart';
import { INVESTIGATIONS_PATH } from '../../../../../common/constants';
import { SERVER_APP_ID } from '../../../../../common';
import type { LinkItem } from '../../../../common/links/types';
Expand Down Expand Up @@ -49,7 +48,7 @@ export const updateInvestigationsLinkFromNotes = (
currentLinks.push({
...noteLink,
description: i18n.NOTE_DESCRIPTION,
landingIcon: IconFilebeatChart,
landingIcon: 'filebeatApp',
});
return {
...investigationsLink,
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/security_solution/public/management/links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import type { CoreStart } from '@kbn/core/public';
import { i18n } from '@kbn/i18n';

import IconFilebeatChart from '../app/solution_navigation/links/sections/icons/filebeat_chart';
import { checkArtifactHasData } from './services/exceptions_list/check_artifact_has_data';
import {
calculateEndpointAuthz,
Expand Down Expand Up @@ -231,7 +230,7 @@ export const links: LinkItem = {
defaultMessage:
'Oversee, revise and revisit the annotations within each document and timeline.',
}),
landingIcon: IconFilebeatChart,
landingIcon: 'filebeatApp',
path: NOTES_PATH,
skipUrlState: true,
hideTimeline: true,
Expand Down

0 comments on commit 5998ecd

Please sign in to comment.