pr Comments

.github/CODEOWNERS

@@ -1861,8 +1861,9 @@ x-pack/plugins/osquery @elastic/security-defend-workflows
 /x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/setup_technology.* @elastic/fleet @elastic/kibana-cloud-security-posture
 /x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/components/cloud_posture_third_party_support_callout.* @elastic/fleet @elastic/kibana-cloud-security-posture
 /x-pack/plugins/security_solution/public/cloud_security_posture @elastic/kibana-cloud-security-posture
-/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/misconfiguration_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture
-/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/vulnerabilities_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture
+/x-pack/test/security_solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture
+/x-pack/test/security_solution_cypress/cypress/e2e/cloud_security_posture/vulnerabilities_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture
+
 # Security Solution onboarding tour
 /x-pack/plugins/security_solution/public/common/components/guided_onboarding @elastic/security-threat-hunting-explore
 

x-pack/plugins/cloud_security_posture/README.md

@@ -20,7 +20,7 @@ For general guidelines, read [Kibana Testing Guide](https://www.elastic.co/guide
 1. [End-to-End Tests](../../test/cloud_security_posture_functional/config.ts)
 1. [Serverless API Integration tests](../../test_serverless/api_integration/test_suites/security/config.ts)
 1. [Serverless End-to-End Tests](../../test_serverless/functional/test_suites/security/config.ts)
-1. [Cypress End-to-End Tests (Temporary location)](../../test/security_solution_cypress/cypress/e2e/cloud_security_posture)
+1. [Cypress End-to-End Tests](../../test/security_solution_cypress/cypress/e2e/cloud_security_posture)
 
 
 ### Tools

x-pack/test/security_solution_cypress/cypress/README.md

@@ -79,6 +79,8 @@ Run the tests with the following yarn scripts from `x-pack/test/security_solutio
 | cypress:detection_engine:run:serverless | Runs all tests tagged as SERVERLESS in the `e2e/detection_response/detection_engine` excluding `e2e/detection_response/detection_engine` directory in headless mode |
 | cypress:ai_assistant:run:ess | Runs all tests tagged as ESS in the `e2e/ai_assistant` directory in headless mode |
 | cypress:ai_assistant:run:serverless | Runs all tests tagged as SERVERLESS in the `e2e/ai_assistant` directory in headless mode |
+| cypress:cloud_security_posture:run:ess | Runs all tests tagged as ESS in the `e2e/cloud_security_posture` directory in headless mode |
+| cypress:cloud_security_posture:run:serverless | Runs all tests tagged as SERVERLESS in the `e2e/cloud_security_posture` directory in headless mode |
 | cypress:detection_engine:exceptions:run:serverless | Runs all tests tagged as ESS in the `e2e/detection_response/detection_engine/exceptions` directory in headless mode |
 | cypress:investigations:run:ess | Runs all tests tagged as SERVERLESS in the `e2e/investigations` directory in headless mode |
 | cypress:explore:run:ess | Runs all tests tagged as ESS in the `e2e/explore` directory in headless mode |
@@ -88,6 +90,7 @@ Run the tests with the following yarn scripts from `x-pack/test/security_solutio
 | cypress:run:qa:serverless:entity_analytics | Runs all tests tagged as SERVERLESS placed in the `e2e/entity_analytics` directory in headless mode using the QA environment and real MKI projects.|
 | cypress:run:qa:serverless:explore | Runs all tests tagged as SERVERLESS in the `e2e/explore` directory in headless mode using the QA environment and real MKI prorjects. |
 | cypress:run:qa:serverless:investigations | Runs all tests tagged as SERVERLESS in the `e2e/investigations` directory in headless mode using the QA environment and reak MKI projects. |
+| cypress:run:qa:serverless:cloud_security_posture | Runs all tests tagged as SERVERLESS in the `e2e/cloud_security_posture` directory in headless mode using the QA environment and reak MKI projects. |
 | cypress:run:qa:serverless:rule_management | Runs all tests tagged as SERVERLESS in the `e2e/detection_response/rule_management` directory, excluding `e2e/detection_response/rule_management/prebuilt_rules` in headless mode using the QA environment and reak MKI projects. |
 | cypress:run:qa:serverless:rule_management:prebuilt_rules | Runs all tests tagged as SERVERLESS in the `e2e/detection_response/rule_management/prebuilt_rules` directory in headless mode using the QA environment and reak MKI projects. |
 | cypress:run:qa:serverless:detection_engine | Runs all tests tagged as SERVERLESS in the `e2e/detection_response/detection_engine` directory, excluding `e2e/detection_response/detection_engine/exceptions` in headless mode using the QA environment and reak MKI projects. |

x-pack/test/security_solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

@@ -29,12 +29,14 @@ const CSP_INSIGHT_TABLE = getDataTestSubjectSelector(
   'securitySolutionFlyoutMisconfigurationFindingsTable'
 );
 
+const clickMisconfigurationTitle = () => {
+  cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click();
+};
+
 const timestamp = Date.now();
 
-// Create a Date object using the timestamp
 const date = new Date(timestamp);
 
-// Convert the Date object to ISO 8601 format
 const iso8601String = date.toISOString();
 
 const mockFindingHostName = (matches: boolean) => {
@@ -46,7 +48,7 @@ const mockFindingHostName = (matches: boolean) => {
       name: 'kubelet',
       sub_type: 'lower case sub type',
     },
-    result: { evaluation: matches ? 'passed' : 'failed' }, // Adjusting result based on matches
+    result: { evaluation: matches ? 'passed' : 'failed' },
     rule: {
       name: 'Upper case rule name',
       section: 'Upper case section',
@@ -74,7 +76,7 @@ const mockFindingUserName = (matches: boolean) => {
       name: 'kubelet',
       sub_type: 'lower case sub type',
     },
-    result: { evaluation: matches ? 'passed' : 'failed' }, // Adjusting result based on matches
+    result: { evaluation: matches ? 'passed' : 'failed' },
     rule: {
       name: 'Upper case rule name',
       section: 'Upper case section',
@@ -132,6 +134,7 @@ describe('Alert Host details expandable flyout', { tags: ['@ess', '@serverless']
     });
 
     afterEach(() => {
+      /* Deleting data stream even though we don't create it because data stream is automatically created when Cloud security API is used  */
       deleteDataStream();
     });
 
@@ -141,7 +144,7 @@ describe('Alert Host details expandable flyout', { tags: ['@ess', '@serverless']
     });
 
     it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => {
-      cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click();
+      clickMisconfigurationTitle();
       cy.get(CSP_INSIGHT_TAB_TITLE).should('be.visible');
       cy.get(CSP_INSIGHT_TABLE).should('be.visible');
     });
@@ -186,7 +189,7 @@ describe('Alert Host details expandable flyout', { tags: ['@ess', '@serverless']
     });
 
     it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => {
-      cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click();
+      clickMisconfigurationTitle();
       cy.get(CSP_INSIGHT_TAB_TITLE).should('be.visible');
       cy.get(CSP_INSIGHT_TABLE).should('be.visible');
     });

x-pack/test/security_solution_cypress/cypress/e2e/cloud_security_posture/vulnerabilities_contextual_flyout.cy.ts

@@ -27,10 +27,8 @@ const CSP_INSIGHT_VULNERABILITIES_TABLE = getDataTestSubjectSelector(
 
 const timestamp = Date.now();
 
-// Create a Date object using the timestamp
 const date = new Date(timestamp);
 
-// Convert the Date object to ISO 8601 format
 const iso8601String = date.toISOString();
 
 const getMockVulnerability = (isNameMatchesAlert: boolean) => {
@@ -166,6 +164,7 @@ describe('Alert Host details expandable flyout', { tags: ['@ess', '@serverless']
       });
 
       afterEach(() => {
+        /* Deleting data stream even though we don't create it because data stream is automatically created when Cloud security API is used  */
         deleteDataStream();
       });