PR comments

elastic · Oct 22, 2024 · 6630153 · 6630153
1 parent aeda8ac
commit 6630153
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/.../plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx b/.../plugins/security_solution/public/common/components/header_actions/add_note_icon_item.tsx
@@ -15,7 +15,7 @@ import { ActionIconItem } from './action_icon_item';
 const NOTES_DISABLE_TOOLTIP = i18n.translate(
   'xpack.securitySolution.timeline.body.notes.disableEventTooltip',
   {
-    defaultMessage: 'Notes may not be added here while editing a template timeline',
+    defaultMessage: 'Notes cannot be added here while editing a template Timeline.',
   }
 );
 const NOTES_ADD_TOOLTIP = i18n.translate(

diff --git a/x-pack/plugins/security_solution/public/notes/components/search_row.tsx b/x-pack/plugins/security_solution/public/notes/components/search_row.tsx
@@ -31,14 +31,14 @@ const searchBox = {
   'data-test-subj': SEARCH_BAR_TEST_ID,
 };
 const associatedNoteSelectOptions: EuiSelectOption[] = [
-  { value: AssociatedFilter.all, text: 'All notes' },
-  { value: AssociatedFilter.documentOnly, text: 'Attached to alerts/events only' },
-  { value: AssociatedFilter.savedObjectOnly, text: 'Attached to Timelines only' },
+  { value: AssociatedFilter.all, text: 'Anything or nothing' },
+  { value: AssociatedFilter.documentOnly, text: 'Alerts or events only' },
+  { value: AssociatedFilter.savedObjectOnly, text: 'Timelines only' },
   {
     value: AssociatedFilter.documentAndSavedObject,
-    text: 'Attached to alerts/events and Timelines only',
+    text: 'Alerts or events and Timelines only',
   },
-  { value: AssociatedFilter.orphan, text: 'Unattached notes' },
+  { value: AssociatedFilter.orphan, text: 'Nothing' },
 ];
 
 export const SearchRow = React.memo(() => {

diff --git a/...ion/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx b/...ion/public/timelines/components/timeline/tabs/query/query_tab_unified_components.test.tsx
@@ -918,7 +918,7 @@ describe('query tab with unified timeline', () => {
           await waitFor(() => {
             expect(screen.getByTestId('timeline-notes-tool-tip')).toBeInTheDocument();
             expect(screen.getByTestId('timeline-notes-tool-tip')).toHaveTextContent(
-              '1 note available. Click to view it & add more.'
+              '1 note available. Click to view it and add more.'
             );
           });
         },
@@ -975,7 +975,7 @@ describe('query tab with unified timeline', () => {
           await waitFor(() => {
             expect(screen.getByTestId('timeline-notes-tool-tip')).toBeVisible();
             expect(screen.getByTestId('timeline-notes-tool-tip')).toHaveTextContent(
-              '1 note available. Click to view it & add more.'
+              '1 note available. Click to view it and add more.'
             );
           });
         },