[Lens] dont use legacy metric in the suggestions (#197101)

## Summary Fixes #197078
elastic · Oct 22, 2024 · 6f44bf5 · 6f44bf5
1 parent cb56679
commit 6f44bf5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 13 deletions.
diff --git a/x-pack/plugins/lens/public/visualizations/legacy_metric/metric_suggestions.test.ts b/x-pack/plugins/lens/public/visualizations/legacy_metric/metric_suggestions.test.ts
@@ -171,7 +171,7 @@ describe('metric_suggestions', () => {
     expect(rest).toHaveLength(0);
     expect(suggestion).toMatchInlineSnapshot(`
       Object {
-        "hide": false,
+        "hide": true,
         "previewIcon": [Function],
         "score": 0.1,
         "state": Object {
@@ -207,7 +207,7 @@ describe('metric_suggestions', () => {
     expect(rest).toHaveLength(0);
     expect(suggestion).toMatchInlineSnapshot(`
       Object {
-        "hide": false,
+        "hide": true,
         "previewIcon": [Function],
         "score": 0.1,
         "state": Object {

diff --git a/x-pack/plugins/lens/public/visualizations/legacy_metric/metric_suggestions.ts b/x-pack/plugins/lens/public/visualizations/legacy_metric/metric_suggestions.ts
@@ -52,7 +52,7 @@ function getSuggestion(
 
   return {
     title,
-    hide: datasourceId === 'textBased',
+    hide: true,
     score: 0.1,
     previewIcon: IconChartMetric,
     state: {

diff --git a/x-pack/plugins/lens/public/visualizations/metric/suggestions.test.ts b/x-pack/plugins/lens/public/visualizations/metric/suggestions.test.ts
@@ -159,7 +159,7 @@ describe('metric suggestions', () => {
               // should ignore bucketed column for initial drag
             },
             title: 'Metric',
-            hide: true,
+            hide: false,
             previewIcon: IconChartMetric,
             score: 0.51,
           },
@@ -189,7 +189,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: true,
+            hide: false,
             previewIcon: IconChartMetric,
             score: 0.51,
           },
@@ -221,7 +221,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: true,
+            hide: false,
             previewIcon: IconChartMetric,
             score: 0.51,
           },
@@ -294,7 +294,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: true,
+            hide: false,
             previewIcon: IconChartMetric,
             score: 0.52,
           },
@@ -326,7 +326,7 @@ describe('metric suggestions', () => {
               breakdownByAccessor: bucketColumn.columnId,
             },
             title: 'Metric',
-            hide: true,
+            hide: false,
             previewIcon: IconChartMetric,
             score: 0.52,
           },
@@ -357,7 +357,7 @@ describe('metric suggestions', () => {
             breakdownByAccessor: bucketColumn.columnId,
           },
           title: 'Metric',
-          hide: true,
+          hide: false,
           previewIcon: IconChartMetric,
           score: 0.52,
         },

diff --git a/x-pack/plugins/lens/public/visualizations/metric/suggestions.ts b/x-pack/plugins/lens/public/visualizations/metric/suggestions.ts
@@ -30,6 +30,8 @@ export const getSuggestions: Visualization<MetricVisualizationState>['getSuggest
 
   const bucketedColumns = table.columns.filter(({ operation }) => operation.isBucketed);
 
+  const hasInterval = bucketedColumns.some(({ operation }) => operation.scale === 'interval');
+
   const unsupportedColumns = table.columns.filter(
     ({ operation }) => !supportedDataTypes.has(operation.dataType) && !operation.isBucketed
   );
@@ -59,11 +61,10 @@ export const getSuggestions: Visualization<MetricVisualizationState>['getSuggest
       layerId: table.layerId,
       layerType: LayerTypes.DATA,
     },
-    title: metricLabel,
+    title: metricColumns[0]?.operation.label || metricLabel,
     previewIcon: IconChartMetric,
     score: 0.5,
-    // don't show suggestions since we're in tech preview
-    hide: true,
+    hide: hasInterval,
   };
 
   const accessorMappings: Pick<MetricVisualizationState, 'metricAccessor' | 'breakdownByAccessor'> =
@@ -72,7 +73,11 @@ export const getSuggestions: Visualization<MetricVisualizationState>['getSuggest
       breakdownByAccessor: bucketedColumns[0]?.columnId,
     };
 
-  baseSuggestion.score += 0.01 * Object.values(accessorMappings).filter(Boolean).length;
+  baseSuggestion.score = Number(
+    (baseSuggestion.score + 0.01 * Object.values(accessorMappings).filter(Boolean).length).toFixed(
+      2
+    )
+  );
 
   const suggestion = {
     ...baseSuggestion,