Skip to content

Commit

Permalink
[8.16] [ip location processor] provider case fixes (#196735) (#196932)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.16`:
- [[ip location processor] provider case fixes
(#196735)](#196735)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
Gallo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T17:48:21Z","message":"[ip
location processor] provider case fixes
(#196735)","sha":"9fae77470adcb69e094e806deca518dfcc89f424","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[ip
location processor] provider case
fixes","number":196735,"url":"https://github.com/elastic/kibana/pull/196735","mergeCommit":{"message":"[ip
location processor] provider case fixes
(#196735)","sha":"9fae77470adcb69e094e806deca518dfcc89f424"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196735","number":196735,"mergeCommit":{"message":"[ip
location processor] provider case fixes
(#196735)","sha":"9fae77470adcb69e094e806deca518dfcc89f424"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Joe Gallo <[email protected]>
  • Loading branch information
kibanamachine and joegallo authored Oct 18, 2024
1 parent e0d0ff9 commit 849235a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('<ManageProcessors />', () => {

expect(row).toEqual([
database.name,
database.type === 'maxmind' ? 'MaxMind' : 'IPInfo',
database.type === 'maxmind' ? 'MaxMind' : 'IPinfo',
'',
]);
});
Expand Down Expand Up @@ -122,7 +122,7 @@ describe('<ManageProcessors />', () => {
});
});

it('creates an IPInfo database when none with the same name exists', async () => {
it('creates an IPinfo database when none with the same name exists', async () => {
const { actions, exists } = testBed;
const databaseName = 'ASN';
httpRequestsMockHelpers.setCreateDatabasesResponse({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
}),
typeDescription: i18n.translate('xpack.ingestPipelines.processors.description.geoip', {
defaultMessage:
'Adds geo data based on an IP address. Uses geo data from a Maxmind database file.',
'Adds geo data based on an IP address. Uses geo data from a MaxMind database file.',
}),
getDefaultDescription: ({ field }) =>
i18n.translate('xpack.ingestPipelines.processors.defaultDescription.geoip', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const DATABASE_TYPE_OPTIONS = [
{
value: 'ipinfo',
text: i18n.translate('xpack.ingestPipelines.manageProcessors.geoip.ipinfoDatabaseType', {
defaultMessage: 'IPInfo',
defaultMessage: 'IPinfo',
}),
},
];
Expand Down Expand Up @@ -153,7 +153,7 @@ export const getTypeLabel = (type: GeoipDatabase['type']): string => {
}
case 'ipinfo': {
return i18n.translate('xpack.ingestPipelines.manageProcessors.geoip.list.typeIpinfoLabel', {
defaultMessage: 'IPInfo',
defaultMessage: 'IPinfo',
});
}
case 'web': {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
expect(databaseExists).to.be(true);
});

it('Create an IPInfo database', async () => {
it('Create an IPinfo database', async () => {
await pageObjects.ingestPipelines.openCreateDatabaseModal();
await pageObjects.ingestPipelines.fillAddDatabaseForm('ipinfo', 'asn');
await pageObjects.ingestPipelines.clickAddDatabaseButton();
Expand Down Expand Up @@ -80,7 +80,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
database.includes(ipInfoDatabaseName)
);
expect(ipInfoDatabaseRow).to.contain(ipInfoDatabaseName);
expect(ipInfoDatabaseRow).to.contain('IPInfo');
expect(ipInfoDatabaseRow).to.contain('IPinfo');
});

it('Modal to delete a database', async () => {
Expand Down

0 comments on commit 849235a

Please sign in to comment.