[Reporting] Functional test structure & improvements (#114298) (#115021)

* [Reporting] Functional test structure & improvements * show the error of the report generation failure in the test failure * update snapshot * remove import to non-existent functional app test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
elastic · Oct 14, 2021 · c574769 · c574769
1 parent 3a659e6
commit c574769
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 80 deletions.
diff --git a/vars/kibanaPipeline.groovy b/vars/kibanaPipeline.groovy
@@ -191,7 +191,6 @@ def withGcsArtifactUpload(workerName, closure) {
     'x-pack/test/**/screenshots/diff/*.png',
     'x-pack/test/**/screenshots/failure/*.png',
     'x-pack/test/**/screenshots/session/*.png',
-    'x-pack/test/functional/apps/reporting/reports/session/*.pdf',
     'x-pack/test/functional/failure_debug/html/*.html',
     '.es/**/*.hprof'
   ]

diff --git a/x-pack/plugins/reporting/public/lib/__snapshots__/stream_handler.test.ts.snap b/x-pack/plugins/reporting/public/lib/__snapshots__/stream_handler.test.ts.snap
diff --git a/x-pack/plugins/reporting/public/notifier/job_failure.tsx b/x-pack/plugins/reporting/public/notifier/job_failure.tsx
@@ -35,6 +35,7 @@ export const getFailureToast = (
           })}
           color="danger"
           iconType="alert"
+          data-test-errorText={errorText}
         >
           {errorText}
         </EuiCallOut>

diff --git a/x-pack/test/functional/apps/reporting/README.md b/x-pack/test/functional/apps/reporting/README.md
@@ -0,0 +1,18 @@
+## Reporting functional tests
+
+Functional tests on report generation are under the applications that use reporting.
+
+**PDF/PNG Report testing:**
+ - `x-pack/test/functional/apps/canvas/reports.ts`
+ - `x-pack/test/functional/apps/dashboard/reporting/screenshots.ts`
+ - `x-pack/test/functional/apps/lens/lens_reporting.ts`
+ - `x-pack/test/functional/apps/visualize/reporting.ts`
+
+**CSV Report testing:**
+ - `x-pack/test/functional/apps/dashboard/reporting/download_csv.ts`
+ - `x-pack/test/functional/apps/discover/reporting.ts`
+
+Reporting Management app tests are in `functional/apps/reporting_management`.
+
+**Manage reports testing:**
+ - `x-pack/test/functional/apps/reporting_management` 
diff --git a/x-pack/test/functional/apps/reporting/index.ts b/x-pack/test/functional/apps/reporting/index.ts
diff --git a/x-pack/test/functional/apps/reporting/reporting.ts b/x-pack/test/functional/apps/reporting/reporting.ts
diff --git a/x-pack/test/functional/config.js b/x-pack/test/functional/config.js
@@ -57,7 +57,6 @@ export default async function ({ readConfigFile }) {
       resolve(__dirname, './apps/transform'),
       resolve(__dirname, './apps/reporting_management'),
       resolve(__dirname, './apps/management'),
-      resolve(__dirname, './apps/reporting'),
 
       //This upgrade assistant file needs to be run after the rest of the jobs because of
       //it being destructive.

diff --git a/x-pack/test/functional/page_objects/reporting_page.ts b/x-pack/test/functional/page_objects/reporting_page.ts
@@ -19,6 +19,7 @@ export class ReportingPageObject extends FtrService {
   private readonly retry = this.ctx.getService('retry');
   private readonly security = this.ctx.getService('security');
   private readonly testSubjects = this.ctx.getService('testSubjects');
+  private readonly find = this.ctx.getService('find');
   private readonly share = this.ctx.getPageObject('share');
   private readonly timePicker = this.ctx.getPageObject('timePicker');
 
@@ -33,15 +34,21 @@ export class ReportingPageObject extends FtrService {
   async getReportURL(timeout: number) {
     this.log.debug('getReportURL');
 
-    const url = await this.testSubjects.getAttribute(
-      'downloadCompletedReportButton',
-      'href',
-      timeout
-    );
-
-    this.log.debug(`getReportURL got url: ${url}`);
-
-    return url;
+    try {
+      const url = await this.testSubjects.getAttribute(
+        'downloadCompletedReportButton',
+        'href',
+        timeout
+      );
+      this.log.debug(`getReportURL got url: ${url}`);
+
+      return url;
+    } catch (err) {
+      const errorTextEl = await this.find.byCssSelector('[data-test-errorText]');
+      const errorText = await errorTextEl.getAttribute('data-test-errorText');
+      const newError = new Error(`Test report failed: ${errorText}: ${err}`);
+      throw newError;
+    }
   }
 
   async removeForceSharedItemsContainerSize() {