[Security Solution][Notes] - fetch notes by saved object ids (#193930)

elastic · Oct 1, 2024 · ca46f78 · ca46f78
1 parent 9d671f6
commit ca46f78
Show file tree

Hide file tree

Showing 44 changed files with 2,889 additions and 1,068 deletions.
diff --git a/oas_docs/output/kibana.serverless.staging.yaml b/oas_docs/output/kibana.serverless.staging.yaml
@@ -14921,6 +14921,10 @@ paths:
           name: documentIds
           schema:
             $ref: '#/components/schemas/Security_Timeline_API_DocumentIds'
+        - in: query
+          name: savedObjectIds
+          schema:
+            $ref: '#/components/schemas/Security_Timeline_API_SavedObjectIds'
         - in: query
           name: page
           schema:
@@ -31674,6 +31678,12 @@ components:
         - threat_match
         - zeek
       type: string
+    Security_Timeline_API_SavedObjectIds:
+      oneOf:
+        - items:
+            type: string
+          type: array
+        - type: string
     Security_Timeline_API_SavedObjectResolveAliasPurpose:
       enum:
         - savedObjectConversion

diff --git a/oas_docs/output/kibana.staging.yaml b/oas_docs/output/kibana.staging.yaml
@@ -18351,6 +18351,10 @@ paths:
           name: documentIds
           schema:
             $ref: '#/components/schemas/Security_Timeline_API_DocumentIds'
+        - in: query
+          name: savedObjectIds
+          schema:
+            $ref: '#/components/schemas/Security_Timeline_API_SavedObjectIds'
         - in: query
           name: page
           schema:
@@ -39683,6 +39687,12 @@ components:
         - threat_match
         - zeek
       type: string
+    Security_Timeline_API_SavedObjectIds:
+      oneOf:
+        - items:
+            type: string
+          type: array
+        - type: string
     Security_Timeline_API_SavedObjectResolveAliasPurpose:
       enum:
         - savedObjectConversion

diff --git a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.gen.ts
@@ -21,6 +21,9 @@ import { Note } from '../model/components.gen';
 export type DocumentIds = z.infer<typeof DocumentIds>;
 export const DocumentIds = z.union([z.array(z.string()), z.string()]);
 
+export type SavedObjectIds = z.infer<typeof SavedObjectIds>;
+export const SavedObjectIds = z.union([z.array(z.string()), z.string()]);
+
 export type GetNotesResult = z.infer<typeof GetNotesResult>;
 export const GetNotesResult = z.object({
   totalCount: z.number(),
@@ -30,6 +33,7 @@ export const GetNotesResult = z.object({
 export type GetNotesRequestQuery = z.infer<typeof GetNotesRequestQuery>;
 export const GetNotesRequestQuery = z.object({
   documentIds: DocumentIds.optional(),
+  savedObjectIds: SavedObjectIds.optional(),
   page: z.string().nullable().optional(),
   perPage: z.string().nullable().optional(),
   search: z.string().nullable().optional(),

diff --git a/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml b/x-pack/plugins/security_solution/common/api/timeline/get_notes/get_notes_route.schema.yaml
@@ -17,6 +17,10 @@ paths:
           in: query
           schema:
             $ref: '#/components/schemas/DocumentIds'
+        - name: savedObjectIds
+          in: query
+          schema:
+            $ref: '#/components/schemas/SavedObjectIds'
         - name: page
           in: query
           schema:
@@ -65,6 +69,12 @@ components:
           items:
             type: string
         - type: string
+    SavedObjectIds:
+      oneOf:
+        - type: array
+          items:
+            type: string
+        - type: string
     GetNotesResult:
       type: object
       required: [totalCount, notes]

diff --git a/...y_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml b/...y_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
@@ -63,6 +63,10 @@ paths:
           name: documentIds
           schema:
             $ref: '#/components/schemas/DocumentIds'
+        - in: query
+          name: savedObjectIds
+          schema:
+            $ref: '#/components/schemas/SavedObjectIds'
         - in: query
           name: page
           schema:
@@ -1359,6 +1363,12 @@ components:
         - threat_match
         - zeek
       type: string
+    SavedObjectIds:
+      oneOf:
+        - items:
+            type: string
+          type: array
+        - type: string
     SavedObjectResolveAliasPurpose:
       enum:
         - savedObjectConversion

diff --git a/...ion/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml b/...ion/docs/openapi/serverless/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
@@ -63,6 +63,10 @@ paths:
           name: documentIds
           schema:
             $ref: '#/components/schemas/DocumentIds'
+        - in: query
+          name: savedObjectIds
+          schema:
+            $ref: '#/components/schemas/SavedObjectIds'
         - in: query
           name: page
           schema:
@@ -1359,6 +1363,12 @@ components:
         - threat_match
         - zeek
       type: string
+    SavedObjectIds:
+      oneOf:
+        - items:
+            type: string
+          type: array
+        - type: string
     SavedObjectResolveAliasPurpose:
       enum:
         - savedObjectConversion

diff --git a/x-pack/plugins/security_solution/public/common/mock/global_state.ts b/x-pack/plugins/security_solution/public/common/mock/global_state.ts
@@ -527,12 +527,14 @@ export const mockGlobalState: State = {
     ids: ['1'],
     status: {
       fetchNotesByDocumentIds: ReqStatus.Idle,
+      fetchNotesBySavedObjectIds: ReqStatus.Idle,
       createNote: ReqStatus.Idle,
       deleteNotes: ReqStatus.Idle,
       fetchNotes: ReqStatus.Idle,
     },
     error: {
       fetchNotesByDocumentIds: null,
+      fetchNotesBySavedObjectIds: null,
       createNote: null,
       deleteNotes: null,
       fetchNotes: null,

diff --git a/x-pack/plugins/security_solution/public/flyout/document_details/left/components/add_note.tsx b/x-pack/plugins/security_solution/public/flyout/document_details/left/components/add_note.tsx