Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] create strategy for embeddable interaction customization #169983

Open
drewdaemon opened this issue Oct 26, 2023 · 4 comments
Open

[Lens] create strategy for embeddable interaction customization #169983

drewdaemon opened this issue Oct 26, 2023 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Oct 26, 2023

Background

Consumers of the Lens embeddable (both directly and through wrappers like portable dashboards and unified histogram) often want to customize the user interactions in various parts of the embedded Lens experience.

We currently offer many ways to do this, each added as a need arose. Yet, we continue to have requests for further customizations. This may continue into the foreseeable future.

The ask for this issue is to take a comprehensive look at the situation and define an API that is easy to understand and extend.

Interaction locations

  • panel context menu items
Screenshot 2023-10-26 at 1 26 24 PM
  • legend menu items
Screenshot 2023-10-26 at 1 27 29 PM
  • table cell actions
Screenshot 2023-10-26 at 1 28 30 PM
  • tooltip actions
Screenshot 2023-10-26 at 1 29 38 PM
  • chart interactions (clicks, brushes)
Screenshot 2023-10-26 at 1 35 57 PM

Desired customizations

  • Adding consumer-defined items to a menu
  • Overriding default behavior of various user interactions and default options and menu items
  • Hiding and showing menu items based on

Efforts to date

@drewdaemon drewdaemon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@drewdaemon drewdaemon changed the title [Lens] create strategy for embeddable action customization [Lens] create strategy for embeddable interaction customization Oct 26, 2023
@drewdaemon drewdaemon added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Oct 26, 2023
@stratoula stratoula added enhancement New value added to drive a business result Feature:Lens labels Oct 27, 2023
@drewdaemon
Copy link
Contributor Author

We also have to account for portable dashboards (see this bug #171167).

@drewdaemon
Copy link
Contributor Author

@timductive timductive added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Nov 15, 2023
@drewdaemon
Copy link
Contributor Author

A suggestion from @angorayc:

Please consider registering Lens default actions to ui actions and talk to ui-actions team about a request to add an new api, for example, replaceExistingAction to src/plugins/ui_actions/public/service/ui_actions_service.ts
In this case, consumers who need custom actions could use that api to replace the default actions with their custom actions. Thanks so much for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants