[Security Solution][Lens] Check filter action type to hide default filter actions in visualizations

[semd]

Summary

Bug: #171167

The previous implementation solved a different bug using a new shouldShowLegendAction property. This approach had a limitation on the Security Dashboards page since the Security app has no control over the properties passed to the visualization components when they are rendered through portable Dashboards.

This PR fixes the problem by checking if any of the registered actions is a "filter" action type in the visualizations. If customized filter actions are found, the default filter actions hardcoded in the visualizations code are not added, preventing duplication of filter actions.

The specific action type used for the check is the FILTER_CELL_ACTION_TYPE = 'cellAction-filter' constant exported by the @kbn/cell-actions package.

This new approach uses a property stored in the registered actions themselves, so we don't need to pass any extra property to the visualization components, it works transparently. So the shouldShowLegendAction property has also been cleaned.

Demos

Timeline using showTopN visualization:

viz_filter_actions_timeline_demo.mov

Alerts page using Counts table visualization and showTopN visualization

viz_filter_actions_alerts_demo.mov

Portable Dashboard visualizations:

viz_filter_actions_dashboards_demo.mov

Security actions are "compatible" only inside the Security app, in the Lens app the default filter actions are displayed:

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[angorayc]

Thanks so much for fixing this, tested locally and LGTM 👍

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 31a73a0

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
expressionPartitionVis	161	163	+2
expressionXY	221	223	+2
lens	1135	1137	+2
securitySolution	4692	4691	-1
total			+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/cell-actions	44	42	-2
expressions	1765	1749	-16
total			-18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
expressionPartitionVis	40.8KB	41.0KB	+197.0B
expressionXY	132.1KB	131.4KB	-704.0B
lens	1.4MB	1.4MB	+72.0B
securitySolution	12.8MB	12.8MB	-16.1KB
total			-16.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
expressions	98.3KB	98.1KB	-175.0B
expressionXY	38.7KB	38.7KB	-48.0B
total			-223.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/cell-actions	62	60	-2
expressions	2224	2208	-16
total			-18

History

• 💔 Build #176755 failed f57b9cb
• 💚 Build #176513 succeeded 6754f28
• 💚 Build #176261 succeeded 4c6aebd
• 💔 Build #176158 failed 05d49db
• 💔 Build #176141 failed f82c888

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

[drewdaemon]

This looks good. We can revisit in #169983.

Thank you for also cleaning up the previous shouldShowLegendAction fix!