Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console Monaco Migration] Implement editor features #176723

Closed
7 of 15 tasks
yuliacech opened this issue Feb 12, 2024 · 2 comments
Closed
7 of 15 tasks

[Console Monaco Migration] Implement editor features #176723

yuliacech opened this issue Feb 12, 2024 · 2 comments
Assignees
@yuliacech @ElenaStoeva
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Feb 12, 2024 •
edited by ElenaStoeva
Loading

After #176520 is merged, we need to start re-implementing existing editor features from Ace to Monaco. This issue contains a list of tasks that needs to be addressed.
The existing code is located in legacy/console_editor/editor.tsx and need to be copied to or re-implemented in monaco/monaco_editor.tsx in the directory src/plugins/console/public/application/containers/editor. Ideally the UI should not change during the migration but if needed some features could be updated or removed. Some features can be worked on already but some might need a working language definition (see this issue for more details).

Tasks
Beta Give feedback
  1. Set the initial text value from the url parameter load_from (add hashchange event listener and remove it on component unmount), initialTextValue component prop or DEFAULT_INPUT_VALUE contant #177332
    Feature:Console Team:Kibana Management
    ElenaStoeva
  2. apply the Console settings (fontSize and wrapMode) #178966
    Feature:Console Team:Kibana Management
    ElenaStoeva
  3. Prevent a11y overlay when it's disabled via Console settings settings.isAccessibilityOverlayEnabled #176799
    Feature:Console Team:Kibana Management
    ElenaStoeva
  9. implement buttons (click to send request, copy as curl, open documentation, auto indent) #178990
    Feature:Console Team:Kibana Management
    yuliacech
  11. Migrate output panel to Monaco editor #178941
    Feature:Console Team:Kibana Management
    ElenaStoeva
  12. [Console Migration] Badges for multiple responses in output panel #179522
    Feature:Console Team:Kibana Management
    ElenaStoeva
  13. [Console Migration] Rename accessibility overlay setting in Console settings #179246
    Feature:Console Team:Kibana Management
  14. Improve hook for setting the initial value #179658
    1 of 3
    Feature:Console Team:Kibana Management
  15. Follow-up work for output panel #179905
    2 of 3
    Feature:Console Team:Kibana Management
    ElenaStoeva
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Feb 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech mentioned this issue Feb 15, 2024
Merged
yuliacech added a commit that referenced this issue Feb 19, 2024
@yuliacech @kibanamachine
[Console] Add a dev config for the editor migration (#176520)
4d7f593 
## Summary

This PR adds a dev config to Console to enable a migration to the Monaco
editor. The config value is `false` by default and can be changed by
adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new
custom Monaco language is registered for Console in the package
`kbn/monaco` and will be worked on behind the config flag iteratively in
the next weeks.
To not let the dev config get into 8.13 release, this PR will only be
merged **after** 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing
Console features in the new Monaco editor, see
#176723 and
#176926

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@yuliacech @kibanamachine @fkanout
[Console] Add a dev config for the editor migration (elastic#176520)
9674128 
## Summary

This PR adds a dev config to Console to enable a migration to the Monaco
editor. The config value is `false` by default and can be changed by
adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new
custom Monaco language is registered for Console in the package
`kbn/monaco` and will be worked on behind the config flag iteratively in
the next weeks.
To not let the dev config get into 8.13 release, this PR will only be
merged **after** 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing
Console features in the new Monaco editor, see
elastic#176723 and
elastic#176926

---------

Co-authored-by: kibanamachine <[email protected]>
@yuliacech yuliacech mentioned this issue Mar 22, 2024
Merged
@ElenaStoeva ElenaStoeva mentioned this issue Mar 22, 2024
Merged
@yuliacech yuliacech mentioned this issue Apr 5, 2024
Closed
@yuliacech
Copy link
Contributor Author

Closing in favor of #180207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

@ElenaStoeva ElenaStoeva

Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuliacech @elasticmachine @ElenaStoeva