[Console] Add a dev config for the editor migration #176520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Feature:Console
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
ElenaStoeva
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Thanks for working on this @yuliacech! Tested locally the new editor, code changes also LGTM 👍
Dosant
approved these changes
Feb 19, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.14.0
backport:skip
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary This PR adds a dev config to Console to enable a migration to the Monaco editor. The config value is `false` by default and can be changed by adding `console.dev.enableMonaco: true` to `kibana.dev.yml`. Also a new custom Monaco language is registered for Console in the package `kbn/monaco` and will be worked on behind the config flag iteratively in the next weeks. To not let the dev config get into 8.13 release, this PR will only be merged **after** 8.13 has been branched. After this PR is merged, the team will start re-implementing existing Console features in the new Monaco editor, see elastic#176723 and elastic#176926 --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a dev config to Console to enable a migration to the Monaco editor. The config value is
falseby default and can be changed by addingconsole.dev.enableMonaco: truetokibana.dev.yml. Also a new custom Monaco language is registered for Console in the packagekbn/monacoand will be worked on behind the config flag iteratively in the next weeks.To not let the dev config get into 8.13 release, this PR will only be merged after 8.13 has been branched.
After this PR is merged, the team will start re-implementing existing Console features in the new Monaco editor, see #176723 and #176926