Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Multiple apps missing <h1> tag or content for <h1> tag or have nesting defects #61870

Closed
5 of 10 tasks
barlowm opened this issue Mar 30, 2020 · 12 comments
Closed
5 of 10 tasks
Labels
bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort Meta obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:SIEM triage_needed WCAG AA

Comments

@barlowm
Copy link
Collaborator

barlowm commented Mar 30, 2020

Dashboard page
The initial panel with the dashboard name (sample data sets) is an H3, where others are H2s, creating a nesting mis-match. Screenshot at the bottom of the description.

Discover page

<discover-app class="app-container">
<h1 class="euiScreenReaderOnly"></h1>
  • Dashboard
  • Discover
  • Canvas page - No <h1> Tag at all
  • Machine Learning page - No <h1> Tag at all
  • Metrics page - No <h1> Tag at all
  • Logs page - No <h1> Tag at all
  • APM page - HAS <h1> Tag but heading nesting is not maintained (<h1> followed by an <h3>)
  • Uptime page - HAS <h1> Tag but heading nesting is not maintained (<h1> followed by an <h3>)
  • SIEM page - No <h1> Tag at all
  • Dev Tools - HAS <h1> Tag but heading nesting is not maintained (<h1> followed by an <h2> followed by an <h4>)

Kibana Version:
7.6.2

OS:
Windows 7

Browser:
Chrome

Screen reader: [if relevant]
N/A

Relevant WCAG Criteria: [#.#.# WCAG Criterion - Level A/AA/AAA](link to https://www.w3.org/WAI/WCAG21/quickref/)
2.4.6 - Headings and Labels - Level AA
Headings and labels describe topic or purpose.

Screenshots
Screen Shot 2021-10-07 at 3 50 56 PM

@barlowm barlowm added bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG AA labels Mar 30, 2020
@myasonik myasonik added loe:small Small Level of Effort Meta labels Oct 1, 2020
@1Copenut
Copy link
Contributor

This seems correlated with #42379. I'm in favor of setting focus on the H1 of a page view when we swap URLs using client-side routing, so screen readers announce the change properly. I'll do some more research, but I think these are related items.

@botelastic botelastic bot added the needs-team Issues missing a team label label May 3, 2022
@teresaalvarezsoler teresaalvarezsoler added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label May 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 5, 2022
@cqliu1 cqliu1 self-assigned this Jun 28, 2022
@Heenawter Heenawter self-assigned this Jun 30, 2022
@Heenawter Heenawter removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jul 12, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 12, 2022
@Heenawter
Copy link
Contributor

I have removed the @elastic/kibana-presentation tag, because we have completed both the Canvas and Dashboard requests 👍

@jughosta
Copy link
Contributor

Discover page: fixed in #129789

@mbondyra mbondyra added Team:SIEM Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels Jul 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 18, 2022
@justinkambic
Copy link
Contributor

justinkambic commented Jul 18, 2022

PR for Uptime here: #136559

EDIT: Uptime fix merged.

@1Copenut
Copy link
Contributor

Machine Learning section has appropriate H1 tags in 8.5 main branch pulled to local machine on 12 September.

@barlowm
Copy link
Collaborator Author

barlowm commented Aug 30, 2024

Issue no longer observed in current version of Kibana (ver Kibana-8.13.2)

@alexwizp
Copy link
Contributor

alexwizp commented Oct 3, 2024

Closed due to the previous comment

@alexwizp alexwizp closed this as completed Oct 3, 2024
@smith smith added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added obs-accessibilty A11Y issues in the Obs. solution. and removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort Meta obs-accessibilty A11Y issues in the Obs. solution. Project:Accessibility Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:SIEM triage_needed WCAG AA
Projects
None yet
Development

No branches or pull requests