[Dashboard] (Accessibility) Adds an H1 tag with the dashboard title #135757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
Feature:Dashboard
Heenawter
force-pushed
the
fix-dashboard-tag-order_2022-06-29
branch
from
e15e95a
to
e770c1e
Compare
Heenawter
force-pushed
the
fix-dashboard-tag-order_2022-06-29
branch
2 times, most recently
from
a51fb15
to
4958dc3
Compare
Heenawter
force-pushed
the
fix-dashboard-tag-order_2022-06-29
branch
from
4958dc3
to
942c0c1
Compare
ThomThomson
approved these changes
Jul 6, 2022
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Heenawter
added
the
release_note:skip
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Heenawter |
|
SharedUX changes LGTM 👍 |
sebelga
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #61870.
Summary
@elastic/kibana-presentation This PR adds an
<h1>tag with the dashboard title for screen readers only and focuses on that title when navigating to the dashboard for the first time, as well as when the dashboard changes from view to edit mode - this helps give more context to the audio clues as the user switches between view modes.For example, whereas before clicking the
Editbutton would not give any audio message stating that the view mode switched, this will now trigger the<h1>tag to be read out which will say something like "Dashboard - Editing<dashboard title name>".Screen.Recording.2022-07-06.at.9.20.00.AM.mov
@elastic/shared-ux This PR also addresses the issues brought up with the sample dashboards in #61870. All sample dashboards start with a markdown element that has the name of the dashboard as a header of that panel - however, previously, this header was an
h3element. To follow a11y standards, I switched this to anh2element - note that this has style implications, as follows:Checklist
For maintainers