-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] 8.0 breaking changes #83256
Comments
Pinging @elastic/apm-ui (Team:apm) |
Some other fields we should consider making required:
Simply put, we should look into making all fields that we aggregate on via a terms or composite aggregation required, as using |
Thanks @dgieselaar. I'll talk to the server team about this. |
Controversial, but we might want to consider to require one and only one environment per service. Supporting multiple environments per service makes both our application code and our UX more complicated. The workaround is adding the environment of a service in a title which seems acceptable (to me). |
@dgieselaar Understood that it has created way more complexity in our application code than probably necessary, but I think that mostly stems from not having a default environment to begin with. IMO if we remove the ability to separate environment data but group under the same service name, there's no need for environments in the first place (also controversial). Users will be instructed to separate by name easing the burden of maintaining environment names and for us the complexity of service name, transaction type, and environment combinations. Alternatively, we could consider only supporting a set of environment names ( |
If we don't use environment to separate data (ie, remove the environment filter entirely) that's even better. The user can still use custom visualisations that do separate by service.environment. |
|
|
Hi 👋! I wanted to point out that there is now a deprecations service (#94845) provided by core to register deprecations within Kibana. All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions! |
TODO: Make list of breaking changes in apm ui, and whether they should be migrated via the upgrade assistant.
Decided
xpack.apm.*
config settings ([APM] Deprecate obsoletexpack.apm.serviceMapEnabled
config options #96278)apm_oss
app ([APM] Deprecateapm_oss
app #108160)doc_count
(must be multiplied by sampling rate)apm_user
([APM] Replaceapm_user
with stack-wide roles (editor
/viewer
) #116760)Up for discussion
These can be tabled for now:
consider creating a single identifier for a service (combination ofservice.name
,service.environment
,tranasction.type
)service.environment
required in agent (Set defaultservice.environment
apm-server#4468)The text was updated successfully, but these errors were encountered: