[Reporting] Fix flaky download pdf test #105210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
jloleysens
added
the
release_note:skip
|
@elasticmachine merge upstream |
tsullivan
approved these changes
Jul 13, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
jloleysens
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
* added a retry for checking that we are on the dashboard landing page * added .only and removed .skip * remove .only * revert this: added .only for flaky test runner * Remove .only Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
* added a retry for checking that we are on the dashboard landing page * added .only and removed .skip * remove .only * revert this: added .only for flaky test runner * Remove .only Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 15, 2021
* added a retry for checking that we are on the dashboard landing page * added .only and removed .skip * remove .only * revert this: added .only for flaky test runner * Remove .only Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Jul 15, 2021
* added a retry for checking that we are on the dashboard landing page * added .only and removed .skip * remove .only * revert this: added .only for flaky test runner * Remove .only Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #102722
Unskips a flaky test and adds a retry to ensure that we are on the "dashboards" landing page. Looking at the screenshots of the failure instances we are getting stuck looking for the breadcrumb link to the dashboard home page when we are already on the dashboard home page.
The current implementation retries the check for whether we are on the landing page for a set amount of time, it could be that, on occasion, the check is running to early and we are falling back to looking for the dashboard breadcrumb which we can't find.