[Reporting] Fix ability to export CSV on searched data with frozen indices #109976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
tsullivan
commented
Aug 24, 2021
x-pack/plugins/reporting/server/export_types/csv_searchsource/generate_csv/generate_csv.ts
Outdated
Show resolved
Hide resolved
tsullivan
force-pushed
the
reporting/fix-csvsearchsource-frozen-idxes
branch
2 times, most recently
from
f46fdcf
to
63c1aeb
Compare
tsullivan
force-pushed
the
reporting/fix-csvsearchsource-frozen-idxes
branch
from
ba0dc89
to
e55ba57
Compare
tsullivan
commented
Aug 24, 2021
x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts
Outdated
Show resolved
Hide resolved
…earch_frozen_indices.ts
tsullivan
force-pushed
the
reporting/fix-csvsearchsource-frozen-idxes
branch
from
4dd6c86
to
bb2585b
Compare
jloleysens
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
This looks great @tsullivan , thanks for adding the functional test 👏🏻
...k/plugins/reporting/server/export_types/csv_searchsource/generate_csv/get_export_settings.ts
Outdated
Show resolved
Hide resolved
x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 26, 2021
…dices (elastic#109976) * use include frozen setting in csv export * add api integration test * add fixes * Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts * test polish * update per feedback
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 26, 2021
…dices (elastic#109976) * use include frozen setting in csv export * add api integration test * add fixes * Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts * test polish * update per feedback
ppisljar
reviewed
Aug 30, 2021
| @@ -45,6 +45,7 @@ export const KBN_SCREENSHOT_HEADER_BLOCK_LIST = [ | |||
|
|
|||
| export const KBN_SCREENSHOT_HEADER_BLOCK_LIST_STARTS_WITH_PATTERN = ['proxy-']; | |||
|
|
|||
| export const UI_SETTINGS_SEARCH_INCLUDE_FROZEN = 'search:includeFrozen'; | |||
There was a problem hiding this comment.
cc @lukasolson shouldn't this setting be respected inside search service ? (and as such we should not need to set it here ?)
There was a problem hiding this comment.
Looks like this setting is only respected with the ESE_SEARCH_STRATEGY. Unfortunately, CSV export can not use that search strategy because it doesn't support scroll queries: #110679 (comment)
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #109167
CSV Export should search frozen indices if the Advanced Setting
search:includeFrozenistrueChecklist
Delete any items that are not applicable to this PR.