-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Fix ability to export CSV on searched data with frozen indices #109976
[Reporting] Fix ability to export CSV on searched data with frozen indices #109976
Conversation
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Pinging @elastic/kibana-app-services (Team:AppServices) |
x-pack/plugins/reporting/server/export_types/csv_searchsource/generate_csv/generate_csv.ts
Outdated
Show resolved
Hide resolved
f46fdcf
to
63c1aeb
Compare
ba0dc89
to
e55ba57
Compare
x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts
Outdated
Show resolved
Hide resolved
…earch_frozen_indices.ts
4dd6c86
to
bb2585b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @tsullivan , thanks for adding the functional test 👏🏻
...k/plugins/reporting/server/export_types/csv_searchsource/generate_csv/get_export_settings.ts
Outdated
Show resolved
Hide resolved
x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
…dices (elastic#109976) * use include frozen setting in csv export * add api integration test * add fixes * Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts * test polish * update per feedback
…dices (elastic#109976) * use include frozen setting in csv export * add api integration test * add fixes * Update x-pack/test/reporting_api_integration/reporting_and_security/search_frozen_indices.ts * test polish * update per feedback
@@ -45,6 +45,7 @@ export const KBN_SCREENSHOT_HEADER_BLOCK_LIST = [ | |||
|
|||
export const KBN_SCREENSHOT_HEADER_BLOCK_LIST_STARTS_WITH_PATTERN = ['proxy-']; | |||
|
|||
export const UI_SETTINGS_SEARCH_INCLUDE_FROZEN = 'search:includeFrozen'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lukasolson shouldn't this setting be respected inside search
service ? (and as such we should not need to set it here ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed: #110679
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this setting is only respected with the ESE_SEARCH_STRATEGY
. Unfortunately, CSV export can not use that search strategy because it doesn't support scroll
queries: #110679 (comment)
Summary
Fixes #109167
CSV Export should search frozen indices if the Advanced Setting
search:includeFrozen
istrue
Checklist
Delete any items that are not applicable to this PR.