[reporting] Move chromium user data to path.data #112198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently reporting manages a Chromium profile in /tmp. This contains browser data and screenshots used to generate PDFs. By moving this to the data directory, we're able to inherit fs permissions created by the deb and rpm packages, or user defined settings.
jbudz
added
Team:Operations
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Thanks @tsullivan! Do you have any thoughts on backporting this to 7.16? I don't foresee issues given this is mostly a temporary folder, but may not have the full picture. |
|
@jbudz I don't see any issues with porting this to 7.x/7.16. Thanks! |
jbudz
added
v7.16.0
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 15, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2021
Co-authored-by: Jonathan Budzenski <[email protected]>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently reporting manages a Chromium profile in /tmp. This contains
browser data and screenshots used to generate PDFs. By moving this to
the data directory, we're able to inherit fs permissions created by the
deb and rpm packages, or user defined settings.