Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Re-enable test for large CSV export from Discover #113675

Merged

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Oct 1, 2021

Summary

Close #112186

image

Testing this PR:
Run these commands from the root directory of the kibana repo:

  1. Run functional tests server: node ./scripts/functional_tests_server.js --config x-pack/test/functional/config.js
  2. Run the functional test: node ./scripts/functional_test_runner --config x-pack/test/functional/config.js --grep='generates a large export'

@tsullivan tsullivan added blocker v8.0.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan requested a review from a team October 6, 2021 22:56
@tsullivan tsullivan enabled auto-merge (squash) October 6, 2021 22:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, happy for this to be merged once CI is green!

@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit ba11cb3 into elastic:master Oct 7, 2021
tsullivan added a commit to tsullivan/kibana that referenced this pull request Oct 7, 2021
…c#113675)

* [Reporting] Re-enable test for large CSV export from Discover

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
tsullivan added a commit that referenced this pull request Oct 11, 2021
…113675) (#114374)

* [Reporting] Re-enable test for large CSV export from Discover (#113675)

* [Reporting] Re-enable test for large CSV export from Discover

* update snapshot

Co-authored-by: Kibana Machine <[email protected]>

* update snapshots

Co-authored-by: Kibana Machine <[email protected]>
@tsullivan tsullivan deleted the reporting/test-large-export-enable branch February 11, 2022 17:47
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting/CSV Export] exported search data is randomly missing rows
5 participants