Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] [Reporting] Fix unhandled promise rejection thrown when launching Chromium (#118119) #118284

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

tsullivan
Copy link
Member

Backports the following commits to 8.0:

…omium (elastic#118119)

* [Reporting] Fix unhandled promise rejection thrown when launching Chromium

* comment correction

* simplify

* unit test

* Update x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts

Co-authored-by: Michael Dokolin <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Michael Dokolin <[email protected]>
@tsullivan tsullivan enabled auto-merge (squash) November 11, 2021 05:34
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #13 / Licensing plugin server client changes in license types provides changes in license types

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit fe1e60f into elastic:8.0 Nov 11, 2021
@tsullivan tsullivan deleted the backport/8.0/pr-118119 branch December 27, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants