-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Es Archiver][Load Action] High Water Mark to 5000, Concurrency 4; Override-able #167993
Changes from 18 commits
fde6123
5b13e60
f15ef44
5c3fc17
21259d3
973c24a
8477411
dfbd49b
3e1eb0f
dc98bd2
6b58e00
e32c315
88ee17d
9fe0bf2
98dda23
a7b1345
043c3ac
ea3cc8c
f10157e
2614b5a
2536763
08e5d8a
8a98410
bc612ba
33444be
6c2d0c8
ea1669a
6648445
8430f34
2c5c9c5
b1336e2
d8a3263
686f566
bf36d8f
d9750eb
17761dc
299a528
ad2c808
46050ee
6aaf355
17271bf
8fe606a
309f789
31757ec
7ae344c
9cf5909
5d815da
bcfb4b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ export function createIndexDocRecordsStream( | |
await client.helpers.bulk( | ||
{ | ||
retries: 5, | ||
concurrency: 4, | ||
datasource: docs.map((doc) => { | ||
const body = doc.source; | ||
const op = doc.data_stream ? BulkOperation.Create : operation; | ||
|
@@ -68,7 +69,7 @@ export function createIndexDocRecordsStream( | |
} | ||
|
||
return new Writable({ | ||
highWaterMark: 300, | ||
highWaterMark: parseInt((process.env.HIGH_WATER_MARK as string) ?? 5000, 10), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here: I know we discussed it internally, but like we didn't know answer to "why was it set to 300", no one outside Appex-QA will understand about HIGH_WATER_MARK variable and new default value. |
||
objectMode: true, | ||
|
||
async write(record, enc, callback) { | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wayneseymour can you add a short comment regarding
concurrency
number decision, so in the future we can quickly understand why it was set to 4.