Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v89.0.0 #168396

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Upgrade EUI to v89.0.0 #168396

merged 7 commits into from
Oct 11, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 9, 2023 •
edited
Loading

v88.5.4⏩v89.0.0

89.0.0

  • Added new pushAnimation prop to push EuiFlyouts, which enables a slide in animation (#7239)
  • Updated EuiComboBox to use EuiInputPopover under the hood (#7246)
  • Added inputPopoverProps to EuiComboBox, which allows customizing the underlying popover (#7246)
  • Added a new beta EuiTextBlockTruncate component for multi-line truncation (#7250)
  • Updated EuiBasicTable and EuiInMemoryTable to support multi-line truncation. This can be set via truncateText.lines in the columns prop. (#7254)

Bug fixes

  • Fixed EuiFlexGroup and EuiFlexGrid's m gutter size (#7251)
  • Fixed focus trap rerender issues in EuiFlyout with memoization (#7259)
  • Fixed a visual bug with EuiContextMenu's animation between panels (#7268)

Breaking changes

  • EUI's global body font-size now respects the font.defaultUnits token. This means that the global font size will use the rem unit by default, instead of px. (#7182)
  • Removed exported accessibleClickKeys, comboBoxKeys, and cascadingMenuKeys services. Use the generic keys service instead (#7256)
  • Removed EuiColorStops due to low usage (#7262)
  • Removed EuiSuggest. We recommend using EuiSelectable or EuiComboBox instead (#7263)
  • Removed euiHeaderAffordForFixed Sass mixin, and $euiHeaderHeight and $euiHeaderHeightCompensation Sass variables. Use the CSS variable --var(euiFixedHeadersOffset, 0) instead. (#7264)

Accessibility

  • When using rem or em font units, EUI now respects, instead of ignoring, browser default font sizes set by end users. (#7182)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.12.0 labels Oct 9, 2023
@cee-chen
[EuiComboBox] Update various RTL to use awaited helpers
d7b1cb1 
- tests fail otherwise, as the popover has `pointer-events: none` while transitioning in
@cee-chen
[EuiFlexGroup/Grid] Update snapshots
4f3bd61
@cee-chen
Update screenshot diff test
7b78469 
- Diff is likely due to fixed `EuiFlexGroup` gap sizing - will leave it to the team to update the screenshots
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1426 1423 -3
visTypeVega 311 308 -3
total -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 201.0KB 201.0KB -1.0B
fleet 1.2MB 1.2MB +1.0B
infra 1.9MB 1.9MB -832.0B
ingestPipelines 360.8KB 360.8KB +1.0B
monitoring 462.4KB 462.4KB -1.0B
securitySolution 13.0MB 13.0MB -4.0B
synthetics 864.5KB 864.5KB -1.0B
uptime 478.2KB 478.2KB -1.0B
visTypeVega 1.8MB 1.8MB -832.0B
total -1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 368.6KB 366.2KB -2.4KB
kbnUiSharedDeps-css 275.0KB 265.1KB -9.8KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -26.6KB
logsShared 219.1KB 219.1KB -1.0B
observability 101.3KB 101.3KB -1.0B
total -38.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review October 9, 2023 22:58
@cee-chen cee-chen requested review from a team as code owners October 9, 2023 22:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

PhilippeOberti
PhilippeOberti approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team!

TinaHeiligers
TinaHeiligers approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core

jgowdyelastic
jgowdyelastic approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

e40pud
e40pud approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DE change LGTM!

janmonschke
janmonschke approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM 👍

@kc13greiner kc13greiner self-requested a review October 10, 2023 12:01
kc13greiner
kc13greiner approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maxcold
maxcold approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud_defend changes LGTM

@1Copenut
Copy link
Contributor

Merging on behalf of Cee for the EUI team.

@1Copenut 1Copenut merged commit 7708814 into elastic:main Oct 11, 2023
34 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 11, 2023
@cee-chen cee-chen deleted the eui-v89.x branch October 12, 2023 01:37
@legrego legrego mentioned this pull request Oct 12, 2023
Closed
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@cee-chen @dej611
Upgrade EUI to v89.0.0 (elastic#168396)
887f985 
`v88.5.4`⏩`v89.0.0`

---

## [`89.0.0`](https://github.com/elastic/eui/tree/v89.0.0)

- Added new `pushAnimation` prop to push `EuiFlyout`s, which enables a
slide in animation ([elastic#7239](elastic/eui#7239))
- Updated `EuiComboBox` to use `EuiInputPopover` under the hood
([elastic#7246](elastic/eui#7246))
- Added `inputPopoverProps` to `EuiComboBox`, which allows customizing
the underlying popover
([elastic#7246](elastic/eui#7246))
- Added a new beta `EuiTextBlockTruncate` component for multi-line
truncation ([elastic#7250](elastic/eui#7250))
- Updated `EuiBasicTable` and `EuiInMemoryTable` to support multi-line
truncation. This can be set via `truncateText.lines` in the `columns`
prop. ([elastic#7254](elastic/eui#7254))

**Bug fixes**

- Fixed `EuiFlexGroup` and `EuiFlexGrid`'s `m` gutter size
([elastic#7251](elastic/eui#7251))
- Fixed focus trap rerender issues in `EuiFlyout` with memoization
([elastic#7259](elastic/eui#7259))
- Fixed a visual bug with `EuiContextMenu`'s animation between panels
([elastic#7268](elastic/eui#7268))

**Breaking changes**

- EUI's global body font-size now respects the `font.defaultUnits`
token. This means that the global font size will use the `rem` unit by
default, instead of `px`.
([elastic#7182](elastic/eui#7182))
- Removed exported `accessibleClickKeys`, `comboBoxKeys`, and
`cascadingMenuKeys` services. Use the generic `keys` service instead
([elastic#7256](elastic/eui#7256))
- Removed `EuiColorStops` due to low usage
([elastic#7262](elastic/eui#7262))
- Removed `EuiSuggest`. We recommend using `EuiSelectable` or
`EuiComboBox` instead
([elastic#7263](elastic/eui#7263))
- Removed `euiHeaderAffordForFixed` Sass mixin, and `$euiHeaderHeight`
and `$euiHeaderHeightCompensation` Sass variables. Use the CSS variable
`--var(euiFixedHeadersOffset, 0)` instead.
([elastic#7264](elastic/eui#7264))

**Accessibility**

- When using `rem` or `em` font units, EUI now respects, instead of
ignoring, browser default font sizes set by end users.
([elastic#7182](elastic/eui#7182))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

@maxcold maxcold maxcold approved these changes

@e40pud e40pud e40pud approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@jcger jcger jcger approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.