Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v90.0.0 #170179

Merged
merged 16 commits into from
Nov 3, 2023
Merged

Upgrade EUI to v90.0.0 #170179

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5def5b3
Upgrade EUI to v90.0.0
cee-chen Oct 30, 2023
33d07d6
i18n changes
cee-chen Oct 30, 2023
6799576
`.defaultProps` removal - Enzyme snapshot updates
cee-chen Oct 31, 2023
a261319
[EuiInputPopover] Update type
cee-chen Oct 30, 2023
34da769
[EuiCommentEvent] Remove now-unnecessary color override
cee-chen Oct 30, 2023
bc79ffc
[EuiCommentEvent] Snapshot updates
cee-chen Oct 31, 2023
adce17a
[EuiContextMenuPanel] Update className
cee-chen Oct 24, 2023
9528498
[EuiContextMenu] Remove now unnecessary CSS specificity
cee-chen Oct 24, 2023
f1d3bde
Fix static usage of EuiContextMenu CSS/DOM
cee-chen Oct 24, 2023
e5e6c46
[EuiContextMenu] Fix test DOM failures
cee-chen Oct 30, 2023
20d3666
[EuiContextMenu][canvas shareable runtime] Update tests to account fo…
cee-chen Oct 30, 2023
e9dc927
[EuiContextMenuPanel] Update snapshots
cee-chen Oct 31, 2023
4f211ca
[EuiContextMenu] Test workaround for animating/transitioning panels
cee-chen Oct 31, 2023
f4c7ac4
[EuiContextMenu] Update FTR/E2E selectors
cee-chen Oct 31, 2023
0657a08
[Lens] Workaround for EuiFieldNumber validity change causing annotati…
cee-chen Oct 31, 2023
3fde6ef
Merge branch 'main' into eui-v90.x
cee-chen Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions x-pack/plugins/security_solution/public/assistant/get_comments/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,10 @@ import {
EuiText,
getDefaultEuiMarkdownParsingPlugins,
getDefaultEuiMarkdownProcessingPlugins,
tint,
} from '@elastic/eui';
import React from 'react';

import { AssistantAvatar } from '@kbn/elastic-assistant';
import { css } from '@emotion/react';
import { euiThemeVars } from '@kbn/ui-theme';
import { CommentActions } from '../comment_actions';
import * as i18n from './translations';
import { customCodeBlockLanguagePlugin } from './custom_codeblock/custom_codeblock_markdown_plugin';
Expand Down Expand Up @@ -105,20 +102,7 @@ export const getComments = ({
message.timestamp.length === 0 ? new Date().toLocaleString() : message.timestamp
),
username: isUser ? i18n.YOU : i18n.ASSISTANT,
...(message.isError
? {
eventColor: 'danger',
css: css`
.euiCommentEvent {
border: 1px solid ${tint(euiThemeVars.euiColorDanger, 0.75)};
}
.euiCommentEvent__header {
padding: 0 !important;
border-block-end: 1px solid ${tint(euiThemeVars.euiColorDanger, 0.75)};
}
`,
}
: {}),
eventColor: message.isError ? 'danger' : undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephmilovic FYI that EuiCommentEvent respecting eventColor for all types is now fixed in EUI, and the workaround you added in #167674 should no longer be necessary - but please feel free to QA and let us know if that's not the case!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thank you!!

};
});
};