[Security Solution][Endpoint][Cypress] Update endpoint cypress config to include videos #170499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help debugging test failures and flakiness
ashokaditya
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Thanks for doing this Ash 👍
Just few hints from my side (unless you just wanted to enable this locally) :)
- would be nice to also include these videos on CI, therefore we need to upload artifacts
- limit the compression so we do not give too hard time to machine's CPU
- filter out the videos of successful specs, therefore just save the failed ones
review changed @tomsonpl
gergoabraham
approved these changes
Nov 3, 2023
delanni
approved these changes
Nov 6, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
tomsonpl
approved these changes
Nov 6, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
ashokaditya
added a commit
to ashokaditya/kibana
that referenced
this pull request
Nov 8, 2023
… to include videos (elastic#170499) ## Summary Adds videos to failed cypress tests for debugging. (cherry picked from commit 1c25217) # Conflicts: # .buildkite/scripts/lifecycle/post_command.sh # x-pack/plugins/security_solution/public/management/cypress/cypress_base.config.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ashokaditya
added a commit
that referenced
this pull request
Nov 14, 2023
… config to include videos (#170499) (#170841) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution][Endpoint][Cypress] Update endpoint cypress config to include videos (#170499)](#170499) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-06T16:04:42Z","message":"[Security Solution][Endpoint][Cypress] Update endpoint cypress config to include videos (#170499)\n\n## Summary\r\n\r\nAdds videos to failed cypress tests for debugging.","sha":"1c2521705a1ece1ebe87740a4c99c27b254630f9","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.11.0","v8.12.0"],"number":170499,"url":"https://github.com/elastic/kibana/pull/170499","mergeCommit":{"message":"[Security Solution][Endpoint][Cypress] Update endpoint cypress config to include videos (#170499)\n\n## Summary\r\n\r\nAdds videos to failed cypress tests for debugging.","sha":"1c2521705a1ece1ebe87740a4c99c27b254630f9"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170499","number":170499,"mergeCommit":{"message":"[Security Solution][Endpoint][Cypress] Update endpoint cypress config to include videos (#170499)\n\n## Summary\r\n\r\nAdds videos to failed cypress tests for debugging.","sha":"1c2521705a1ece1ebe87740a4c99c27b254630f9"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds videos to failed cypress tests for debugging.