Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add proof-of-concept for Fleet settings framework #170539

Closed
wants to merge 4 commits into from
Closed

[Fleet] Add proof-of-concept for Fleet settings framework #170539

wants to merge 4 commits into from

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Nov 3, 2023 •
edited
Loading

Ref https://github.com/elastic/ingest-dev/issues/2471

Screen.Recording.2023-11-07.at.9.48.45.AM.mov

@kpollich kpollich self-assigned this Nov 3, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 7, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #70 / Alerts API @ess @serverless open_close_alerts validation checks update by ids should not give errors when querying and the alerts index does not exist yet
  • [job] [logs] FTR Configs #70 / Alerts API @ess @serverless open_close_alerts validation checks update by query should not give errors when querying and the alerts index does exist and is empty
  • [job] [logs] Investigations - Security Solution Cypress Tests #1 / Correlation tab should update timeline after removing eql should update timeline after removing eql
  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #7 / Detections : Page Filters Impact of inputs should recover from invalid kql Query result should recover from invalid kql Query result
  • [job] [logs] Investigations - Security Solution Cypress Tests #8 / Detections : Page Filters Impact of inputs should recover from invalid kql Query result should recover from invalid kql Query result
  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #7 / Detections : Page Filters Impact of inputs should recover from invalid kql Query result should recover from invalid kql Query result
  • [job] [logs] Investigations - Security Solution Cypress Tests #8 / Detections : Page Filters Impact of inputs should recover from invalid kql Query result should recover from invalid kql Query result

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 944 956 +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.3MB +66.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@nchaulet nchaulet mentioned this pull request Apr 2, 2024
Merged
@kpollich
Copy link
Member Author

kpollich commented Apr 9, 2024

Closing in favor of #179795

@kpollich kpollich closed this Apr 9, 2024
juliaElastic added a commit that referenced this pull request Apr 9, 2024
@nchaulet @kibanamachine @juliaElastic
[Fleet] Settings Framework API and UI (#179795)
c88b3bd 
## Summary

Follow up on #170539
Related to elastic/ingest-dev#2471 (Phase 1)

Dynamically creating settings fields from configuration.
These settings are saved in the agent policy SO's `advanced_settings`
field.
In the current pr the agent policy read/create/update works including
the UI.
It still has to be extended to support a few more type of settings: e.g.
dropdown values, settings consisting of multiple fields.

<img width="2212" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/c2ee7187-41bf-42a4-8a22-f43ea8ccfb8c">

These settings are added to the full agent policy agents section:
<img width="687" alt="image"
src="https://github.com/elastic/kibana/assets/90178898/05e244f3-148c-4c88-9b9c-fd665fd0154c">


## Old description:

Add support for saved object mapping and api field name,

## Example API calls and full policy generation

<img width="600" alt="Screenshot 2024-04-02 at 3 54 35 PM"
src="https://github.com/elastic/kibana/assets/1336873/ee2ea087-3e02-4351-9138-c56ace1d5b34">
<img width="500" alt="Screenshot 2024-04-02 at 4 13 42 PM"
src="https://github.com/elastic/kibana/assets/1336873/97514b2e-ef39-475e-8a88-1204ce2c0cda">
<img width="600" alt="Screenshot 2024-04-02 at 4 13 54 PM"
src="https://github.com/elastic/kibana/assets/1336873/6553e133-ea07-48b5-b0ec-c45861b9b246">
<img width="600" alt="Screenshot 2024-04-02 at 5 42 27 PM"
src="https://github.com/elastic/kibana/assets/1336873/faa560fd-7303-46f5-ae2e-034fc10dddfd">


## Open questions/Issues

### Saved objects

*I think we will still have to do some work to add a new model version
when adding a new saved object field, I do not see an easy way to
programatically generate that. In a first time it probably could be a
manual action to add those migration

### API

Open api generation, I think as a first iteration it could be a manual
operation to update openAPI spec, but we should be able to
programatically generate that with a script in the future

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kpollich kpollich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpollich @apmmachine @kibana-ci @kibanamachine