[Management] Saved objects to React/EUI! #17426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681.
|
jenkins, test this |
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
|
jenkins, test this |
💚 Build Succeeded |
bmcconaghy
approved these changes
May 17, 2018
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 17, 2018
* Not working proto code * More proto code * Work in progress * Just go back to non interactive searching, much easier * This should be on the server * Revert "[@kbn/ui-framework] move ui-framework to a package (elastic#17085)" This reverts commit ef3339b. * Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (elastic#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681. * Use BasicTable properly * Table improvements * Small tweaks to the table * Improvements * Flyout mostly working * Remove in memory table * Getting close * Tweaks * Revamping server code, still need to support editing * Progress * Fix export * Updates and passing functional tests * Better links in relationships flyout * Add skip import option * Fixes around importing and removing unnecessary code * Remove tags for now * Tests for lib/ * Some fixes * Ensure we clear index pattern cache * Parity with master * Revert any changes in package.json * Reset any changes in this file * Move the new argumen to the end to prevent test failures * Fix functional tests * Add relationship tests * Fix tests * API integration tests for relationships * Ensure we're properly waiting for things to happen * Fix test issue * Wait for the table to finish loading instead of the whole page * Tests for objects_table * Componentry tests * Ensure this is grabbing the right field * Update snapshot * Fixes with importing index patterns * PR feedback * PR feedback * PR feedback * Update snapshot * PR feedback * Update snapshot * Respect the savedObjects:perPage config * Updates from PR feedback * More updates from PR feedback * Make this more efficient * Add debugging for functional test failures * Wait longer * Wrap each button accessor with a retry.try * Try wrapping this in a retry.try * Debug * Lets make sure it is visible * Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish * Rewrite this per suggestions from stacey
chrisronline
added a commit
that referenced
this pull request
May 17, 2018
* [Management] Saved objects to React/EUI! (#17426) * Not working proto code * More proto code * Work in progress * Just go back to non interactive searching, much easier * This should be on the server * Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)" This reverts commit ef3339b. * Revert "Revert "[@kbn/ui-framework] move ui-framework to a package (#17085)"" This reverts commit ce9ce14e1060c426090b55a5367de3ff4329e681. * Use BasicTable properly * Table improvements * Small tweaks to the table * Improvements * Flyout mostly working * Remove in memory table * Getting close * Tweaks * Revamping server code, still need to support editing * Progress * Fix export * Updates and passing functional tests * Better links in relationships flyout * Add skip import option * Fixes around importing and removing unnecessary code * Remove tags for now * Tests for lib/ * Some fixes * Ensure we clear index pattern cache * Parity with master * Revert any changes in package.json * Reset any changes in this file * Move the new argumen to the end to prevent test failures * Fix functional tests * Add relationship tests * Fix tests * API integration tests for relationships * Ensure we're properly waiting for things to happen * Fix test issue * Wait for the table to finish loading instead of the whole page * Tests for objects_table * Componentry tests * Ensure this is grabbing the right field * Update snapshot * Fixes with importing index patterns * PR feedback * PR feedback * PR feedback * Update snapshot * PR feedback * Update snapshot * Respect the savedObjects:perPage config * Updates from PR feedback * More updates from PR feedback * Make this more efficient * Add debugging for functional test failures * Wait longer * Wrap each button accessor with a retry.try * Try wrapping this in a retry.try * Debug * Lets make sure it is visible * Maybe the short timeout is affecting this - use the default timeout which should be higher and allow more time for the animation to finish * Rewrite this per suggestions from stacey * Update snapshots
|
Backport: 6.x: 8455bcd |
This was referenced May 18, 2018
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 19, 2018
This reverts commit 80bb4b1.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
May 19, 2018
elastic#19179)" This reverts commit 8455bcd.
This was referenced Jul 10, 2018
This was referenced Aug 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #15721
Yes, this PR is huge and it's doing quite a bit of things.
The first and most important thing this PR does is maintain parity with the existing saved objects table in terms of pagination, filtering, import, exporting and deleting saved objects.
Parity
Here are some examples of the tested parity:
Existing
PR
The second thing this PR is doing is adding a few improvements!
Improvements
No Conflicts
Conflicts
Testing
This will be fun!
We want to ensure parity with existing searching functionality including known deficiencies but we want want to ensure the import/export flow works properly.
One of the main complications around this was we historically did not export index patterns so if an import occurred with objects that were tied to an index pattern that did not exist in the current kibana instance, we'd have to show a modal to allow the user to resolve those issues. That should not happen in the future if the user exports the index patterns too, but we still need to support this for the foreseeable future.
This logic should not have changed; just moved around and slightly refactored.
The more straightforward way to trigger a conflict is to export everything (exclude the index pattern), delete the existing index patterns within Kibana, recreate those same index patterns (but ensure different ids), then try and import that exported json file.
Some previous issues to verify too: #15981 #14592
TODO
cc @skearns64 @nreese