-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine][FTR] Audit detection engine rule execution FTRs #179765
Draft
yctercero
wants to merge
12
commits into
elastic:main
Choose a base branch
from
yctercero:ftr_detections_executions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,600
−2,426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
yctercero
commented
Apr 10, 2024
@@ -43,11 +43,11 @@ export default ({ getService }: FtrProviderContext) => { | |||
const dataPathBuilder = new EsArchivePathBuilder(isServerless); | |||
const path = dataPathBuilder.getPath('auditbeat/hosts'); | |||
|
|||
// Failing: See https://github.com/elastic/kibana/issues/179704 | |||
describe.skip('@ess @serverless change alert status endpoints', () => { | |||
describe('@ess @serverless change alert status endpoints', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to skip entire suite, just flakey tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continues work on #169185 and #151877 .
Related to #151877 this PR:
/rule_execution
folder that do not require Platinum license into the basics folder. Tests in/rule_execution/trial_license_complete_tier
folder should now relate to functionality that requires the higher license tier.Related to #169185 this PR:
Follow up
Flakey test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5592