Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Settings Framework API and UI #179795
[Fleet] Settings Framework API and UI #179795
Changes from 4 commits
459ed22
b9b1d89
e9da8bf
137b40e
ba36f2a
c319d0c
cc9e820
c87e0d6
4e639a2
07130c4
6761aa1
5223904
85df867
f6f4b56
01c9d53
28741c7
a52d6bb
878bf20
dab2cf2
ba7a56f
f10222f
8f10f68
24f7fab
bc62731
b3a83a7
5020c56
c47b966
6879094
7a78b57
779acf5
ab47145
ddb0925
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the download timeout be a string instead? it seems to accept values like
120s
https://github.com/elastic/elastic-agent/blob/3dab14d123e2e116f61805ef4b67efc47283b03f/elastic-agent.reference.yml#L95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think this is a Go duration string so it should be validated as a string here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
download.target_directory
according to the issueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the
saved_object_field
andapi_field
definition hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used an object here so it easily extendable in the future,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a lot of duplication between number and text type, I wonder if there could be a common component as a wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored this component to use a common
SettingsFieldWrapper