-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the docs with the advanced setting option for enabling Uptime #183613
Updates the docs with the advanced setting option for enabling Uptime #183613
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not sure how Kibana handles backports these days, but don't forget to adjust labels as needed to make sure this gets backported correctly. Thanks for adding this!
I've added @elastic/kibana-docs to review this because I don't think I'm a code owner in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…elastic#183613) ## Summary Updates the [advanced settings docs](https://www.elastic.co/guide/en/kibana/master/advanced-options.html) to include the `observability:enableLegacyUptimeApp` option for enabling the Uptime Kibana app by default (in conjunction with the Observability doc updates in elastic/observability-docs#3890) The list of options (under Observability, at least) don't seem to be alphabetical, so I've put this in where seems to be a good place, but feel free to move it somewhere else if more appropriate. (cherry picked from commit 4182d87)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
… Uptime (#183613) (#184821) # Backport This will backport the following commits from `main` to `8.14`: - [Updates the docs with the advanced setting option for enabling Uptime (#183613)](#183613) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paul Bianciardi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-06-05T10:59:54Z","message":"Updates the docs with the advanced setting option for enabling Uptime (#183613)\n\n## Summary\r\n\r\nUpdates the [advanced settings\r\ndocs](https://www.elastic.co/guide/en/kibana/master/advanced-options.html)\r\nto include the `observability:enableLegacyUptimeApp` option for enabling\r\nthe Uptime Kibana app by default (in conjunction with the Observability\r\ndoc updates in https://github.com/elastic/observability-docs/pull/3890)\r\n\r\nThe list of options (under Observability, at least) don't seem to be\r\nalphabetical, so I've put this in where seems to be a good place, but\r\nfeel free to move it somewhere else if more appropriate.","sha":"4182d87d4a2edfed7762b48706b6ae885fa6896f","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","backport:all-open","v8.15.0"],"title":"Updates the docs with the advanced setting option for enabling Uptime","number":183613,"url":"https://github.com/elastic/kibana/pull/183613","mergeCommit":{"message":"Updates the docs with the advanced setting option for enabling Uptime (#183613)\n\n## Summary\r\n\r\nUpdates the [advanced settings\r\ndocs](https://www.elastic.co/guide/en/kibana/master/advanced-options.html)\r\nto include the `observability:enableLegacyUptimeApp` option for enabling\r\nthe Uptime Kibana app by default (in conjunction with the Observability\r\ndoc updates in https://github.com/elastic/observability-docs/pull/3890)\r\n\r\nThe list of options (under Observability, at least) don't seem to be\r\nalphabetical, so I've put this in where seems to be a good place, but\r\nfeel free to move it somewhere else if more appropriate.","sha":"4182d87d4a2edfed7762b48706b6ae885fa6896f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183613","number":183613,"mergeCommit":{"message":"Updates the docs with the advanced setting option for enabling Uptime (#183613)\n\n## Summary\r\n\r\nUpdates the [advanced settings\r\ndocs](https://www.elastic.co/guide/en/kibana/master/advanced-options.html)\r\nto include the `observability:enableLegacyUptimeApp` option for enabling\r\nthe Uptime Kibana app by default (in conjunction with the Observability\r\ndoc updates in https://github.com/elastic/observability-docs/pull/3890)\r\n\r\nThe list of options (under Observability, at least) don't seem to be\r\nalphabetical, so I've put this in where seems to be a good place, but\r\nfeel free to move it somewhere else if more appropriate.","sha":"4182d87d4a2edfed7762b48706b6ae885fa6896f"}}]}] BACKPORT--> Co-authored-by: Paul Bianciardi <[email protected]>
Summary
Updates the advanced settings docs to include the
observability:enableLegacyUptimeApp
option for enabling the Uptime Kibana app by default (in conjunction with the Observability doc updates in elastic/observability-docs#3890)The list of options (under Observability, at least) don't seem to be alphabetical, so I've put this in where seems to be a good place, but feel free to move it somewhere else if more appropriate.