[SecuritySolution] Remove duplicated serverless tests #188855

angorayc · 2024-07-22T14:36:29Z

Summary

Apply [Security Solution] Update serverless FTR tests to not run with operator privileges #185870 for Security Solution Explore and Investigation tests.
Remove duplicated tests.
Investigation/timeline/serverless tests are skipped atm.

How to run the api integration tests (Use Investigation Timeline ESS as an example)

cd x-pack

node scripts/functional_tests_server.js --config ./test/security_solution_api_integration/test_suites/investigation/timeline/trial_license_complete_tier/configs/ess.config.ts

// After server is started, open another terminal

cd x-pack

node ../scripts/functional_test_runner --config=test/security_solution_api_integration/test_suites/investigation/timeline/trial_license_complete_tier/configs/ess.config.ts

angorayc · 2024-07-22T14:42:13Z

buildkite test this

angorayc · 2024-07-23T09:48:26Z

/ci

angorayc · 2024-07-23T09:58:32Z

...pi_integration/test_suites/investigation/timeline/trial_license_complete_tier/tests/index.ts

@@ -8,7 +8,7 @@
 import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

 export default function ({ loadTestFile }: FtrProviderContextWithSpaces) {
-  describe('@ess SecuritySolution Timeline', () => {
+  describe('@ess @serverless @skipInServerless SecuritySolution Timeline', () => {


Should be included in #183645 (comment)

…fix'

…cement

angorayc · 2024-07-23T13:35:39Z

/ci

angorayc · 2024-07-23T15:47:59Z

/ci

angorayc · 2024-07-24T15:04:27Z

/ci

angorayc · 2024-07-24T16:36:16Z

buildkite test this

…-fix'

angorayc · 2024-07-25T09:28:49Z

/ci

…cement

angorayc · 2024-07-25T15:38:45Z

/ci

angorayc · 2024-07-26T11:12:10Z

/ci

angorayc · 2024-07-26T12:44:00Z

/ci

angorayc · 2024-07-29T09:27:40Z

/ci

angorayc · 2024-07-29T15:02:18Z

/ci

elasticmachine · 2024-07-29T16:57:11Z

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

…cement

…-fix'

dmlemeshko

x-pack/test_serverless/shared/services/bsearch_secure.ts changes LGTM

logeekal

Changes Look good. thank you for the cleanup 🚀

logeekal · 2024-08-02T06:40:20Z

...tegration/test_suites/investigation/timeline/security_and_spaces/configs/ess.basic.config.ts

@@ -20,7 +20,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
        `--xpack.securitySolution.enableExperimental=${JSON.stringify([])}`,
      ],
    },
-    testFiles: [require.resolve('../ess/basic')],
+    testFiles: [require.resolve('../tests/basic')],


@angorayc , are these event running? I could not find a way to run these locally.

currently, in my ticket I was working towards enabling them as a part of MKI. We you able to run them?

In this branch I can see them is part of .buildkite/ftr_security_stateful_configs.yml

x-pack/test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.basic.config.ts

x-pack/test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

I had no problem to run them locally, it just tests in ess.trial.config.ts are skipped.

cd x-pack node scripts/functional_tests_server.js --config ./test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

Once started, in another terminal

cd x-pack node ../scripts/functional_test_runner --config=test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

Ohh okay. I will checkout .buildkite/ftr_security_stateful_configs.yml

I had no problem to run them locally, it just tests in ess.trial.config.ts are skipped

Yes I was working on unskipping those but I was also reorganizing them based on licence similar to other folders so that they can also run in MKI. I need to check how re-org impacts .buildkite/ftr_security_stateful_configs.yml

Thanks for the info @angorayc .

agusruidiazgd · 2024-08-02T12:15:45Z

Approved from security-threat-hunting-explore team

…cement

kibana-ci · 2024-08-06T11:59:04Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 972c308

Failed CI Steps

FTR Configs #26

Test Failures

[job] [logs] FTR Configs #26 / discover/context_awareness extension getDefaultAppState data view mode should render default columns and row height

Metrics [docs]

✅ unchanged

History

💛 Build #225846 was flaky d9ecb36
💔 Build #225840 failed 95db550
💔 Build #225822 failed 869f3fb
💛 Build #225364 was flaky 9826756
💛 Build #224662 was flaky 078d7a2
💔 Build #224641 failed c2466bd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

remove duplicated serverless tests

f723bd5

angorayc changed the title ~~remove duplicated serverless tests~~ [SecuritySolution] Remove duplicated serverless tests Jul 22, 2024

angorayc added 2 commits July 22, 2024 16:28

remove console

d617931

types

ee11041

angorayc mentioned this pull request Jul 23, 2024

[SecuritySolution] Timeline api integration tests #183645

Open

angorayc commented Jul 23, 2024

View reviewed changes

kibanamachine and others added 2 commits July 23, 2024 10:00

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

40dbf62

…fix'

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

aed7547

…cement

fix type error

d259935

angorayc and others added 2 commits July 24, 2024 10:48

update tests dependency

c2b1c0b

Merge branch 'main' into api-tests-enhancement

7c8f9c8

Merge branch 'main' into api-tests-enhancement

620e7e7

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

04f910b

…-fix'

angorayc added 2 commits July 25, 2024 12:09

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

be0b2c3

…cement

update createBsearch

253fc6b

types

df908c3

createBsearch

9826370

createSupertest in tests

70bb80d

Merge branch 'main' into api-tests-enhancement

f7ad85d

types

0a15315

angorayc marked this pull request as ready for review July 29, 2024 16:56

angorayc requested review from a team as code owners July 29, 2024 16:56

angorayc added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore labels Jul 29, 2024

angorayc and others added 4 commits July 30, 2024 11:08

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

6b65b0e

…cement

Merge branch 'main' into api-tests-enhancement

41ac8fd

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

c2466bd

…-fix'

Merge branch 'main' into api-tests-enhancement

078d7a2

dmlemeshko approved these changes Jul 31, 2024

View reviewed changes

Merge branch 'main' into api-tests-enhancement

9826756

logeekal approved these changes Aug 2, 2024

View reviewed changes

agusruidiazgd self-requested a review August 2, 2024 12:11

agusruidiazgd approved these changes Aug 2, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

869f3fb

…cement

angorayc requested a review from agusruidiazgd August 5, 2024 12:09

agusruidiazgd approved these changes Aug 5, 2024

View reviewed changes

angorayc added 4 commits August 5, 2024 14:00

types

95db550

import

d9ecb36

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

3b34691

…cement

Merge branch 'main' of github.com:elastic/kibana into api-tests-enhan…

972c308

…cement

angorayc merged commit 644e818 into elastic:main Aug 6, 2024
21 checks passed

kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution] Remove duplicated serverless tests #188855

[SecuritySolution] Remove duplicated serverless tests #188855

angorayc commented Jul 22, 2024 •

edited

Loading

angorayc commented Jul 22, 2024

angorayc commented Jul 23, 2024

angorayc Jul 23, 2024 •

edited

Loading

angorayc commented Jul 23, 2024

angorayc commented Jul 23, 2024

angorayc commented Jul 24, 2024

angorayc commented Jul 24, 2024

angorayc commented Jul 25, 2024

angorayc commented Jul 25, 2024

angorayc commented Jul 26, 2024

angorayc commented Jul 26, 2024

angorayc commented Jul 29, 2024

angorayc commented Jul 29, 2024

elasticmachine commented Jul 29, 2024

dmlemeshko left a comment

logeekal left a comment

logeekal Aug 2, 2024

angorayc Aug 2, 2024 •

edited

Loading

logeekal Aug 2, 2024

agusruidiazgd commented Aug 2, 2024

kibana-ci commented Aug 6, 2024

[SecuritySolution] Remove duplicated serverless tests #188855

[SecuritySolution] Remove duplicated serverless tests #188855

Conversation

angorayc commented Jul 22, 2024 • edited Loading

Summary

angorayc commented Jul 22, 2024

angorayc commented Jul 23, 2024

angorayc Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

angorayc commented Jul 23, 2024

angorayc commented Jul 23, 2024

angorayc commented Jul 24, 2024

angorayc commented Jul 24, 2024

angorayc commented Jul 25, 2024

angorayc commented Jul 25, 2024

angorayc commented Jul 26, 2024

angorayc commented Jul 26, 2024

angorayc commented Jul 29, 2024

angorayc commented Jul 29, 2024

elasticmachine commented Jul 29, 2024

dmlemeshko left a comment

Choose a reason for hiding this comment

logeekal left a comment

Choose a reason for hiding this comment

logeekal Aug 2, 2024

Choose a reason for hiding this comment

angorayc Aug 2, 2024 • edited Loading

Choose a reason for hiding this comment

logeekal Aug 2, 2024

Choose a reason for hiding this comment

agusruidiazgd commented Aug 2, 2024

kibana-ci commented Aug 6, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

angorayc commented Jul 22, 2024 •

edited

Loading

angorayc Jul 23, 2024 •

edited

Loading

angorayc Aug 2, 2024 •

edited

Loading