Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Remove duplicated serverless tests #188855

Merged
merged 28 commits into from
Aug 6, 2024

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Jul 22, 2024

Summary

  1. Apply [Security Solution] Update serverless FTR tests to not run with operator privileges #185870 for Security Solution Explore and Investigation tests.
  2. Remove duplicated tests.
  3. Investigation/timeline/serverless tests are skipped atm.

How to run the api integration tests (Use Investigation Timeline ESS as an example)

cd x-pack

node scripts/functional_tests_server.js --config ./test/security_solution_api_integration/test_suites/investigation/timeline/trial_license_complete_tier/configs/ess.config.ts

// After server is started, open another terminal

cd x-pack

node ../scripts/functional_test_runner --config=test/security_solution_api_integration/test_suites/investigation/timeline/trial_license_complete_tier/configs/ess.config.ts

@angorayc angorayc changed the title remove duplicated serverless tests [SecuritySolution] Remove duplicated serverless tests Jul 22, 2024
@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

/ci

@@ -8,7 +8,7 @@
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

export default function ({ loadTestFile }: FtrProviderContextWithSpaces) {
describe('@ess SecuritySolution Timeline', () => {
describe('@ess @serverless @skipInServerless SecuritySolution Timeline', () => {
Copy link
Contributor Author

@angorayc angorayc Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be included in #183645 (comment)

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

buildkite test this

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc
Copy link
Contributor Author

/ci

@angorayc angorayc marked this pull request as ready for review July 29, 2024 16:56
@angorayc angorayc requested review from a team as code owners July 29, 2024 16:56
@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore labels Jul 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/test_serverless/shared/services/bsearch_secure.ts changes LGTM

Copy link
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Look good. thank you for the cleanup 🚀

@@ -20,7 +20,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
`--xpack.securitySolution.enableExperimental=${JSON.stringify([])}`,
],
},
testFiles: [require.resolve('../ess/basic')],
testFiles: [require.resolve('../tests/basic')],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angorayc , are these event running? I could not find a way to run these locally.

currently, in my ticket I was working towards enabling them as a part of MKI. We you able to run them?

Copy link
Contributor Author

@angorayc angorayc Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this branch I can see them is part of .buildkite/ftr_security_stateful_configs.yml

  • x-pack/test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.basic.config.ts
  • x-pack/test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

I had no problem to run them locally, it just tests in ess.trial.config.ts are skipped.

cd x-pack

node scripts/functional_tests_server.js --config ./test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

Once started, in another terminal

cd x-pack

node ../scripts/functional_test_runner --config=test/security_solution_api_integration/test_suites/investigation/timeline/security_and_spaces/configs/ess.trial.config.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh okay. I will checkout .buildkite/ftr_security_stateful_configs.yml

I had no problem to run them locally, it just tests in ess.trial.config.ts are skipped

Yes I was working on unskipping those but I was also reorganizing them based on licence similar to other folders so that they can also run in MKI. I need to check how re-org impacts .buildkite/ftr_security_stateful_configs.yml

Thanks for the info @angorayc .

@agusruidiazgd agusruidiazgd self-requested a review August 2, 2024 12:11
@agusruidiazgd
Copy link
Contributor

Approved from security-threat-hunting-explore team

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / discover/context_awareness extension getDefaultAppState data view mode should render default columns and row height

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 644e818 into elastic:main Aug 6, 2024
21 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants