-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview #192643
[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview #192643
Conversation
d1ae0a0
to
11badbd
Compare
11badbd
to
5cd0391
Compare
5cd0391
to
765d865
Compare
765d865
to
0898bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DW changes LGTM!
@elasticmachine merge upstream |
dbd75e9
to
0898bd4
Compare
831ed07
to
9ef2c45
Compare
x-pack/plugins/security_solution/common/experimental_features.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great addition, I love seeing the proper event details preview flyout!!
041b943
to
0898bd4
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Starting backport for target branches: 8.x |
…node schema and enable event preview (elastic#192643) ## Summary This PR added `_id` and `_index` to the resolver event query so that it could support calling an event preview when showing analyzer in flyout. Feature flag: `visualizationInFlyoutEnabled` ![image](https://github.com/user-attachments/assets/7dc27389-0bd5-491f-a1e1-6639c3dae2ed) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7b54d6f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…event node schema and enable event preview (#192643) (#194214) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview (#192643)](#192643) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T19:06:43Z","message":"[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview (#192643)\n\n## Summary\r\n\r\nThis PR added `_id` and `_index` to the resolver event query so that it\r\ncould support calling an event preview when showing analyzer in flyout.\r\n\r\nFeature flag: `visualizationInFlyoutEnabled`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/7dc27389-0bd5-491f-a1e1-6639c3dae2ed)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7b54d6f8010bd3693d42ed62efd7a89637c2b4a4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","8.16 candidate","v8.16.0","backport:version"],"title":"[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview","number":192643,"url":"https://github.com/elastic/kibana/pull/192643","mergeCommit":{"message":"[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview (#192643)\n\n## Summary\r\n\r\nThis PR added `_id` and `_index` to the resolver event query so that it\r\ncould support calling an event preview when showing analyzer in flyout.\r\n\r\nFeature flag: `visualizationInFlyoutEnabled`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/7dc27389-0bd5-491f-a1e1-6639c3dae2ed)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7b54d6f8010bd3693d42ed62efd7a89637c2b4a4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192643","number":192643,"mergeCommit":{"message":"[Security Solution]Analyzer in flyout Part 2 - update analyzer event node schema and enable event preview (#192643)\n\n## Summary\r\n\r\nThis PR added `_id` and `_index` to the resolver event query so that it\r\ncould support calling an event preview when showing analyzer in flyout.\r\n\r\nFeature flag: `visualizationInFlyoutEnabled`\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/7dc27389-0bd5-491f-a1e1-6639c3dae2ed)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"7b54d6f8010bd3693d42ed62efd7a89637c2b4a4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
Summary
This PR added
_id
and_index
to the resolver event query so that it could support calling an event preview when showing analyzer in flyout.Feature flag:
visualizationInFlyoutEnabled
Checklist