You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds kibana:plugin_render_time EBT performance event to Discover plugin. It will be fired when user navigates to one of Discover main views:
Discover Documents tab (when the first data grid row is rendered)
Single Doc page (when tabs are rendered)
Surrounding Docs page (when the first data grid row is rendered)
If the initial page was something else (like error, no data view, Field Statistics tab, etc), then it would report it too and we skip any further tracking as it would not report the correct time between the page visit and getting to the main content. Also navigation between Discover routes will not trigger the event.
Testing
Enable "Usage collection" global setting.
Navigate to Discover and observe kibana-browser requests in Network tab. It will be one of performance_metric event.
To enable logging, add the following to your kibana.dev.yml:
[job][logs] FTR Configs #18 / discover/ccs_compatible saved queries saved objects saved query selection should unselect saved query when navigating to a 'new'
[job][logs] FTR Configs #37 / discover/ccs_compatible saved queries saved objects saved query selection should unselect saved query when navigating to a 'new'
[job][logs] FTR Configs #18 / discover/ccs_compatible saved queries saved objects saved query selection should unselect saved query when navigating to a 'new'
[job][logs] FTR Configs #37 / discover/ccs_compatible saved queries saved objects saved query selection should unselect saved query when navigating to a 'new'
[job][logs] FTR Configs #57 / discover/classic discover doc table legacy expand a document row should show allow toggling columns from the expanded document
[job][logs] FTR Configs #57 / discover/classic discover doc table legacy expand a document row should show allow toggling columns from the expanded document
[job][logs] FTR Configs #8 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #18 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #29 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #99 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #18 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #29 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #8 / discover/context_awareness extension getDefaultAppState ES|QL mode should reset default columns and row height when clicking "New"
[job][logs] FTR Configs #99 / discover/context_awareness extension getDocViewer data view mode should not render logs overview tab for non-logs data source
[job][logs] FTR Configs #81 / discover/esql discover esql columns should render initial columns for non-transformational commands correctly
[job][logs] FTR Configs #81 / discover/esql discover esql columns should render initial columns for non-transformational commands correctly
[job][logs] FTR Configs #7 / discover/group7 discover new search action should work correctly for data view mode
[job][logs] FTR Configs #7 / discover/group7 discover new search action should work correctly for data view mode
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
backport:prev-minorBackport to (8.x) the previous minor version (i.e. one version back from main)Project:OneDiscoverEnrich Discover with contextual awareness / Merge with Logs Explorerrelease_note:skipSkip the PR/issue when compiling release notesTeam:DataDiscoveryDiscover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
kibana:plugin_render_time
EBT performance event to Discover plugin. It will be fired when user navigates to one of Discover main views:If the initial page was something else (like error, no data view, Field Statistics tab, etc), then it would report it too and we skip any further tracking as it would not report the correct time between the page visit and getting to the main content. Also navigation between Discover routes will not trigger the event.
Testing
Enable "Usage collection" global setting.
Navigate to Discover and observe
kibana-browser
requests in Network tab. It will be one ofperformance_metric
event.To enable logging, add the following to your
kibana.dev.yml
:Checklist