fix no-restricted-imports
#195456
Merged
fix no-restricted-imports
#195456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:skip
Dosant
requested review from
machadoum,
pzl,
gergoabraham,
vitaliidm and
jpdjere
|
@elasticmachine merge upstream |
patrykkopycinski
approved these changes
Oct 14, 2024
bhapas
approved these changes
Oct 14, 2024
tomsonpl
approved these changes
Oct 14, 2024
szaffarano
approved these changes
Oct 14, 2024
jaredburgettelastic
approved these changes
Oct 14, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
|
Starting backport for target branches: 8.x |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Oct 16, 2024
## Summary I noticed that our `no-restricted-imports` rules were not working on some parts of the codebase. Turns our the rule was overriden by mistake. This PR fixes the rules and places that were not following them: - lodash set for safety - react-use for a bit smaller bundles - router for context annoncement (`useExecutionContext`) and hopefully easier upgrade to newer version (cherry picked from commit 1055120) # Conflicts: # .github/CODEOWNERS
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Dosant
added a commit
that referenced
this pull request
Oct 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [fix `no-restricted-imports` (#195456)](#195456) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T11:55:53Z","message":"fix `no-restricted-imports` (#195456)\n\n## Summary\r\n\r\nI noticed that our `no-restricted-imports` rules were not working on\r\nsome parts of the codebase. Turns our the rule was overriden by mistake.\r\nThis PR fixes the rules and places that were not following them:\r\n\r\n- lodash set for safety\r\n- react-use for a bit smaller bundles\r\n- router for context annoncement (`useExecutionContext`) and hopefully\r\neasier upgrade to newer version","sha":"1055120d0f4640af67881b4909d4881681d9575d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"number":195456,"url":"https://github.com/elastic/kibana/pull/195456","mergeCommit":{"message":"fix `no-restricted-imports` (#195456)\n\n## Summary\r\n\r\nI noticed that our `no-restricted-imports` rules were not working on\r\nsome parts of the codebase. Turns our the rule was overriden by mistake.\r\nThis PR fixes the rules and places that were not following them:\r\n\r\n- lodash set for safety\r\n- react-use for a bit smaller bundles\r\n- router for context annoncement (`useExecutionContext`) and hopefully\r\neasier upgrade to newer version","sha":"1055120d0f4640af67881b4909d4881681d9575d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195456","number":195456,"mergeCommit":{"message":"fix `no-restricted-imports` (#195456)\n\n## Summary\r\n\r\nI noticed that our `no-restricted-imports` rules were not working on\r\nsome parts of the codebase. Turns our the rule was overriden by mistake.\r\nThis PR fixes the rules and places that were not following them:\r\n\r\n- lodash set for safety\r\n- react-use for a bit smaller bundles\r\n- router for context annoncement (`useExecutionContext`) and hopefully\r\neasier upgrade to newer version","sha":"1055120d0f4640af67881b4909d4881681d9575d"}}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
added
v8.17.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that our
no-restricted-importsrules were not working on some parts of the codebase. Turns our the rule was overriden by mistake. This PR fixes the rules and places that were not following them:useExecutionContext) and hopefully easier upgrade to newer versioncc @elastic/kibana-operations