Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Canvas] Cleanup services (#194634) #195639

Merged
merged 1 commit into from
Oct 9, 2024

Commits on Oct 9, 2024

  1. [Canvas] Cleanup services (elastic#194634)

    Closes elastic#194050
    
    ## Summary
    
    This PR refactors the Canvas services to no longer use the
    `PluginServiceProvider` from the `PresentationUtil` plugin. Note that
    the Canvas storybooks are broken on main (and they have been for who
    knows how long) and so, while I did make some changes to the storybooks
    to make them **compile**, I didn't bother to get them fully functional.
    
    Note that the Ecommerce workpad is broken - this is not due to this PR,
    it is a [bug](elastic#195297) that is
    present on main.
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    
    <!--ONMERGE {"backportTargets":["8.x"]} ONMERGE-->
    
    ---------
    
    Co-authored-by: Catherine Liu <[email protected]>
    (cherry picked from commit 91c045d)
    Heenawter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    82fa144 View commit details
    Browse the repository at this point in the history