Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Isolate CCS check #195988

Merged
merged 17 commits into from
Oct 18, 2024
Merged

[Chore] Isolate CCS check #195988

merged 17 commits into from
Oct 18, 2024

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 11, 2024 •
edited by kibanamachine
Loading

Summary

Isolate CCS check in single location.

Closes #193906 (comment)

For maintainers

@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck thomasneirynck marked this pull request as ready for review October 15, 2024 21:12
@thomasneirynck thomasneirynck requested review from a team as code owners October 15, 2024 21:12
@thomasneirynck thomasneirynck added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development v8.16.0 labels Oct 15, 2024
@thomasneirynck
Copy link
Contributor Author

/ci

stratoula
stratoula reviewed Oct 15, 2024
View reviewed changes
packages/kbn-esql-ast/src/antlr/gen/esql_lexer.interp Outdated
Copy link
Contributor

@stratoula stratoula Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are yoou changing these files Thomas? 🤔 I am expecting zero changes in our code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, that's a mistake. thx!

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

jgowdyelastic
jgowdyelastic approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@thomasneirynck
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 16, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: ce823ed
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195988-ce823ed54753

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / threatMatchRowRenderer #renderRow rendered when indicator matches are more than MAX rendered

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/es-query 209 210 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +28.0B
ml 4.5MB 4.5MB +210.0B
monitoring 533.3KB 533.3KB +10.0B
transform 477.5KB 477.5KB +10.0B
total +258.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +133.0B
Unknown metric groups

API count

id before after diff
@kbn/es-query 269 271 +2

History

@thomasneirynck thomasneirynck marked this pull request as ready for review October 17, 2024 13:14
@thomasneirynck thomasneirynck requested a review from a team as a code owner October 17, 2024 13:14
YulNaumenko
YulNaumenko approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jughosta
jughosta approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

@thomasneirynck thomasneirynck merged commit f86d171 into elastic:main Oct 18, 2024
47 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11403883467

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@thomasneirynck
[Chore] Isolate CCS check (elastic#195988)
debb649 
## Summary

Isolate CCS check in single location.

Closes
elastic#193906 (comment)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f86d171)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@thomasneirynck
[Chore] Isolate CCS check (elastic#195988)
4d13a63 
## Summary

Isolate CCS check in single location.

Closes
elastic#193906 (comment)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f86d171)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@thomasneirynck
[Chore] Isolate CCS check (elastic#195988)
302c7de 
## Summary

Isolate CCS check in single location.

Closes
elastic#193906 (comment)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f86d171)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
@kibanamachine @thomasneirynck
[8.x] [Chore] Isolate CCS check (#195988) (#196869)
bab9084 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Chore] Isolate CCS check
(#195988)](#195988)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thomas
Neirynck","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T12:40:04Z","message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.16.0"],"title":"[Chore]
Isolate CCS
check","number":195988,"url":"https://github.com/elastic/kibana/pull/195988","mergeCommit":{"message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195988","number":195988,"mergeCommit":{"message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Thomas Neirynck <[email protected]>
@kibanamachine kibanamachine added v8.17.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 18, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Oct 22, 2024
@kibanamachine @thomasneirynck
[8.16] [Chore] Isolate CCS check (#195988) (#196868)
9752a92 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[Chore] Isolate CCS check
(#195988)](#195988)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thomas
Neirynck","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T12:40:04Z","message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review","v8.16.0"],"title":"[Chore]
Isolate CCS
check","number":195988,"url":"https://github.com/elastic/kibana/pull/195988","mergeCommit":{"message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195988","number":195988,"mergeCommit":{"message":"[Chore]
Isolate CCS check (#195988)\n\n## Summary\r\n\r\nIsolate CCS check in
single
location.\r\n\r\nCloses\r\nhttps://github.com//issues/193906#issuecomment-2400370478\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"f86d1716b171d846851041d50da074683624fa02"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Thomas Neirynck <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

@consulthys consulthys consulthys approved these changes

@jughosta jughosta jughosta approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@stratoula stratoula Awaiting requested review from stratoula

Assignees
No one assigned
Labels
apm:review backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development chore ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Audit] CCS : index pattern delimiter parsing