Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Bash #196393

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[Cloud Security] Fix for Contextual Flyout UI bugs from Bug Bash #196393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../cloud_security_posture/components/csp_details/vulnerabilities_findings_details_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
{ defaultMessage: 'CVSS' }
),
width: '12.5%',
width: '15%',
},
{
field: 'vulnerability',
Expand All @@ -165,7 +165,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
{ defaultMessage: 'Severity' }
),
width: '12.5%',
width: '20%',
},
{
field: 'vulnerability',
Expand All @@ -176,7 +176,7 @@ export const VulnerabilitiesFindingsDetailsTable = memo(({ queryName }: { queryN
'xpack.securitySolution.flyout.left.insights.vulnerability.table.ruleColumnName',
{ defaultMessage: 'Package' }
),
width: '50%',
width: '40%',
},
];

Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/cloud_security_posture/components/entity_insight.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ export const EntityInsight = <T,>({
insightContent.push(
<>
<MisconfigurationsPreview name={name} fieldName={fieldName} isPreviewMode={isPreviewMode} />
<EuiSpacer size="m" />
<EuiSpacer size="s" />
</>
);
if (isVulnerabilitiesFindingForHost && hasVulnerabilitiesFindings)
insightContent.push(
<>
<VulnerabilitiesPreview name={name} isPreviewMode={isPreviewMode} />
<EuiSpacer size="m" />
<EuiSpacer size="s" />
</>
);
return (
Expand Down
9 changes: 4 additions & 5 deletions ...on/public/cloud_security_posture/components/misconfiguration/misconfiguration_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ const MisconfigurationPreviewScore = ({
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
<EuiTitle size="s">
<h1>{`${Math.round((passedFindings / (passedFindings + failedFindings)) * 100)}%`}</h1>
<h3>{`${Math.round((passedFindings / (passedFindings + failedFindings)) * 100)}%`}</h3>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem>
<EuiText
size="m"
size="xs"
css={css`
font-weight: ${euiTheme.font.weight.semiBold};
`}
Expand Down Expand Up @@ -217,8 +217,7 @@ export const MisconfigurationsPreview = ({
header={{
iconType: !isPreviewMode && hasMisconfigurationFindings ? 'arrowStart' : '',
title: (
<EuiText
size="xs"
<EuiTitle
css={css`
font-weight: ${euiTheme.font.weight.semiBold};
`}
Expand All @@ -227,7 +226,7 @@ export const MisconfigurationsPreview = ({
id="xpack.securitySolution.flyout.right.insights.misconfigurations.misconfigurationsTitle"
defaultMessage="Misconfigurations"
/>
</EuiText>
</EuiTitle>
),
link: hasMisconfigurationFindings ? link : undefined,
}}
Expand Down
9 changes: 4 additions & 5 deletions ...tion/public/cloud_security_posture/components/vulnerabilities/vulnerabilities_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ const VulnerabilitiesCount = ({
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
<EuiTitle size="s">
<h1>{vulnerabilitiesTotal}</h1>
<h3>{vulnerabilitiesTotal}</h3>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem>
<EuiText
size="m"
size="xs"
css={css`
font-weight: ${euiTheme.font.weight.semiBold};
`}
Expand Down Expand Up @@ -153,8 +153,7 @@ export const VulnerabilitiesPreview = ({
header={{
iconType: !isPreviewMode && hasVulnerabilitiesFindings ? 'arrowStart' : '',
title: (
<EuiText
size="xs"
<EuiTitle
css={css`
font-weight: ${euiTheme.font.weight.semiBold};
`}
Expand All @@ -163,7 +162,7 @@ export const VulnerabilitiesPreview = ({
id="xpack.securitySolution.flyout.right.insights.vulnerabilities.vulnerabilitiesTitle"
defaultMessage="Vulnerabilities"
/>
</EuiText>
</EuiTitle>
),
link,
}}
Expand Down